Skip to content

Commit 86d0975

Browse files
committed
Refactor audio upload functionality to remove unused parameters
- Removed `auto_generate_client` and `folder` parameters from audio upload functions to streamline the API. - Updated related function calls and documentation to reflect these changes, enhancing clarity and reducing complexity.
1 parent d7f716d commit 86d0975

File tree

4 files changed

+6
-14
lines changed

4 files changed

+6
-14
lines changed

backends/advanced/src/advanced_omi_backend/controllers/audio_controller.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,6 @@ async def upload_and_process_audio_files(
4040
user: User,
4141
files: list[UploadFile],
4242
device_name: str = "upload",
43-
auto_generate_client: bool = True,
44-
folder: str = None,
4543
source: str = "upload"
4644
) -> dict:
4745
"""
@@ -56,8 +54,7 @@ async def upload_and_process_audio_files(
5654
user: Authenticated user
5755
files: List of uploaded audio files
5856
device_name: Device identifier
59-
auto_generate_client: Whether to auto-generate client ID
60-
folder: Optional subfolder for audio storage (e.g., 'fixtures')
57+
source: Source of the upload (e.g., 'upload', 'gdrive')
6158
"""
6259
try:
6360
if not files:

backends/advanced/src/advanced_omi_backend/routers/modules/audio_routes.py

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,14 @@ async def upload_audio_from_drive_folder(
3131
gdrive_folder_id: str = Query(..., description="Google Drive Folder ID containing audio files (e.g., the string after /folders/ in the URL)"),
3232
current_user: User = Depends(current_superuser),
3333
device_name: str = Query(default="upload"),
34-
auto_generate_client: bool = Query(default=True),
3534
):
3635
try:
3736
files = await download_audio_files_from_drive(gdrive_folder_id, current_user.id)
38-
except AudioValidationError as e:
37+
except AudioValidationError as e:
3938
raise HTTPException(status_code=400, detail=str(e))
4039

4140
return await audio_controller.upload_and_process_audio_files(
42-
current_user, files, device_name, auto_generate_client, source="gdrive"
41+
current_user, files, device_name, source="gdrive"
4342
)
4443

4544

@@ -399,19 +398,17 @@ async def upload_audio_files(
399398
current_user: User = Depends(current_superuser),
400399
files: list[UploadFile] = File(...),
401400
device_name: str = Query(default="upload", description="Device name for uploaded files"),
402-
auto_generate_client: bool = Query(default=True, description="Auto-generate client ID"),
403-
folder: Optional[str] = Query(default=None, description="Optional subfolder for audio storage (e.g., 'fixtures')"),
404401
):
405402
"""
406403
Upload and process audio files. Admin only.
407404
408-
Audio files are saved to disk and enqueued for processing via RQ jobs.
405+
Audio files are stored as MongoDB chunks and enqueued for processing via RQ jobs.
409406
This allows for scalable processing of large files without blocking the API.
410407
411408
Returns:
412409
- List of uploaded files with their processing job IDs
413410
- Summary of enqueued vs failed uploads
414411
"""
415412
return await audio_controller.upload_and_process_audio_files(
416-
current_user, files, device_name, auto_generate_client, folder
413+
current_user, files, device_name
417414
)

backends/advanced/webui/src/pages/Upload.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ export default function Upload() {
4949
await uploadApi.uploadFromGDriveFolder({
5050
gdrive_folder_id: gdriveFolderId,
5151
device_name: 'upload',
52-
auto_generate_client: true,
5352
})
5453

5554
setGdriveUploadStatus({

backends/advanced/webui/src/services/api.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -275,12 +275,11 @@ export const uploadApi = {
275275
},
276276
}),
277277

278-
uploadFromGDriveFolder: (payload: { gdrive_folder_id: string; device_name?: string; auto_generate_client?: boolean }) =>
278+
uploadFromGDriveFolder: (payload: { gdrive_folder_id: string; device_name?: string }) =>
279279
api.post('/api/audio/upload_audio_from_gdrive', null, {
280280
params: {
281281
gdrive_folder_id: payload.gdrive_folder_id,
282282
device_name: payload.device_name,
283-
auto_generate_client: payload.auto_generate_client,
284283
},
285284
timeout: 300000,
286285
}),

0 commit comments

Comments
 (0)