wizard.py (1)

426-428: Remove extraneous f-string prefixes.

These strings have no placeholders, so the f prefix is unnecessary. Per Ruff F541.

-    console.print(f"[dim]   cd backends/advanced && uv run --with-requirements ../../setup-requirements.txt python init.py[/dim]")
-    console.print(f"[dim]   cd extras/speaker-recognition && uv run --with-requirements ../../setup-requirements.txt python init.py[/dim]")
-    console.print(f"[dim]   cd extras/asr-services && uv run --with-requirements ../../setup-requirements.txt python init.py[/dim]")
+    console.print("[dim]   cd backends/advanced && uv run --with-requirements ../../setup-requirements.txt python init.py[/dim]")
+    console.print("[dim]   cd extras/speaker-recognition && uv run --with-requirements ../../setup-requirements.txt python init.py[/dim]")
+    console.print("[dim]   cd extras/asr-services && uv run --with-requirements ../../setup-requirements.txt python init.py[/dim]")

extras/asr-services/init.py (3)

92-128: Move re import to top of file and fix string version comparison.

Two issues:

1. Per coding guidelines, the import re on line 113 should be at the top of the file.

2. The string comparison cuda_ver >= "12.8" is fragile. String comparison works lexicographically, so "9.0" >= "12.1" would incorrectly evaluate to True. While current CUDA versions happen to work, this could break with future versions.

Add at top of file:

import re

And consider using tuple comparison for robustness:

                     if match:
                         major, minor = match.groups()
-                        cuda_ver = f"{major}.{minor}"
-
-                        # Map to available PyTorch CUDA versions
-                        if cuda_ver >= "12.8":
-                            return "cu128"
-                        elif cuda_ver >= "12.6":
-                            return "cu126"
-                        elif cuda_ver >= "12.1":
-                            return "cu121"
+                        cuda_ver = (int(major), int(minor))
+                        
+                        # Map to available PyTorch CUDA versions
+                        if cuda_ver >= (12, 8):
+                            return "cu128"
+                        elif cuda_ver >= (12, 6):
+                            return "cu126"
+                        elif cuda_ver >= (12, 1):
+                            return "cu121"

---

126-128: Avoid silent failure; consider logging or warning the user.

Per coding guidelines, errors should not be silently ignored. The bare pass hides potential issues. Consider at minimum logging a debug message or informing the user that CUDA detection failed.

-        except (subprocess.SubprocessError, FileNotFoundError):
-            pass
+        except (subprocess.SubprocessError, FileNotFoundError) as e:
+            self.console.print(f"[dim]Could not detect CUDA version: {e}. Using default.[/dim]")
         return "cu126"  # Default fallback to cu126

---

249-251: Improve exception handling: avoid bare Exception and use proper logging.

Per coding guidelines, always raise errors explicitly rather than silently failing. Per retrieved learnings, prefer logging.exception() inside except blocks to capture the full stack trace, and chain exceptions with raise ... from e when re-raising.

Since this is a top-level handler that exits, consider logging the full traceback for debugging:

+import logging
+
+logger = logging.getLogger(__name__)

Then update the exception handler:

         except Exception as e:
-            self.console.print(f"[red][ERROR][/red] Setup failed: {e}")
+            logger.exception("Setup failed")
+            self.console.print(f"[red][ERROR][/red] Setup failed: {e}")
             sys.exit(1)

Alternatively, if you want to keep it simple without adding logging infrastructure, at least use import traceback and print the traceback for debugging:

         except Exception as e:
+            import traceback
+            traceback.print_exc()
             self.console.print(f"[red][ERROR][/red] Setup failed: {e}")
             sys.exit(1)

Based on learnings, this improves debuggability.

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Learnt from: AnkushMalaker
Repo: chronicler-ai/chronicle PR: 178
File: backends/advanced/src/advanced_omi_backend/services/memory/providers/mycelia.py:218-223
Timestamp: 2025-12-08T23:52:34.959Z
Learning: In Python code (chronicle project), prefer logging.exception() inside except blocks to automatically log the full stack trace. When re-raising exceptions, always chain with 'raise ... from e' to preserve the original context; use 'raise ... from None' only if you explicitly want to suppress the context. This improves debuggability across Python files.