Skip to content

Update Docker configuration to use PYTORCH_CUDA_VERSION instead of CU…#215

Merged
AnkushMalaker merged 1 commit intodevfrom
fix/cuda-var-name
Dec 18, 2025
Merged

Update Docker configuration to use PYTORCH_CUDA_VERSION instead of CU…#215
AnkushMalaker merged 1 commit intodevfrom
fix/cuda-var-name

Conversation

@AnkushMalaker
Copy link
Collaborator

@AnkushMalaker AnkushMalaker commented Dec 18, 2025 •
edited by coderabbitai bot
Loading

…DA_VERSION for Parakeet ASR builds

Summary by CodeRabbit

  • Chores
    • Updated build configuration naming conventions for CUDA/PyTorch variant support consistency across container builds.

✏️ Tip: You can customize this high-level summary in your review settings.

@AnkushMalaker AnkushMalaker merged commit 267e3bc into dev Dec 18, 2025
1 check was pending
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 18, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

Environment variable and Docker build argument renamed from CUDA_VERSION to PYTORCH_CUDA_VERSION across CI/CD workflow and docker-compose configuration files for consistent CUDA variant propagation during container builds.

Changes

Cohort / File(s) Summary
CUDA variant propagation
.github/workflows/advanced-docker-compose-build.yml, extras/asr-services/docker-compose-test.yml		 Renamed CUDA version variable from CUDA_VERSION to PYTORCH_CUDA_VERSION in exported environment variable (workflow) and build ARG (docker-compose), maintaining default value cu126.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

  • Simple variable rename across two configuration files with consistent pattern
  • No functional logic changes or behavioral modifications

Poem

🐰 A whisker-twitching rename so neat,
CUDA calls out with a brand new beat,
PYTORCH_CUDA in the files so bright,
Docker containers building just right! ✨

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/cuda-var-name
📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9a2b3f9 and 74b9696.

📒 Files selected for processing (2)
  • .github/workflows/advanced-docker-compose-build.yml (1 hunks)
  • extras/asr-services/docker-compose-test.yml (1 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

@AnkushMalaker AnkushMalaker deleted the fix/cuda-var-name branch December 18, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@AnkushMalaker