Fix some redaction issues

Author: Simyon264

ReplayBrowser/Helpers/ReplayHelper.cs

@@ -248,6 +248,9 @@ public async Task<int> GetTotalReplayCount()
 
     private Replay FilterReplay(Replay replay, Account? caller = null)
     {
+        if (replay.RoundEndPlayers == null)
+            return replay;
+        
         foreach (var replayRoundEndPlayer in replay.RoundEndPlayers)
         {
             var accountForPlayer = _accountService.GetAccountSettings(replayRoundEndPlayer.PlayerGuid);

ReplayBrowser/Services/AccountService.cs

@@ -180,6 +180,7 @@ public async Task UpdateAccount(Account? account)
         using var scope = _scopeFactory.CreateScope();
         var context = scope.ServiceProvider.GetRequiredService<ReplayDbContext>();
         context.Accounts.Update(account);
+        GenerateAccountSettings();
         await context.SaveChangesAsync();
     }
 

ReplayBrowser/Services/LeaderboardService.cs

@@ -152,18 +152,23 @@ public async Task<LeaderboardData> GetLeaderboard(RangeOption rangeOption, strin
             });
         }
 
-        if (username != null && accountCaller != null)
+        if (username != null)
         {
             var accountRequested = await context.Accounts
                 .Include(a => a.Settings)
                 .FirstOrDefaultAsync(a => a.Username.ToLower() == username.ToLower());
 
-            if (accountRequested != null && accountRequested.Settings.RedactInformation &&
-                (accountCaller == null || accountCaller.Guid != accountRequested.Guid))
+            if (accountRequested != null)
             {
-                if (accountCaller == null || !accountCaller.IsAdmin)
+                if (accountRequested.Settings.RedactInformation)
                 {
-                    throw new UnauthorizedAccessException("This user has chosen to privatize their information.");
+                    if (accountRequested.Id != accountCaller?.Id)
+                    {
+                        if (accountCaller is not { IsAdmin: true })
+                        {
+                            throw new UnauthorizedAccessException("This user has chosen to privatize their information.");
+                        }
+                    }
                 }
             }
         }