Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Polling Termination Logic to use finished_processing attribute #185

Open
KPreisner opened this issue Dec 9, 2024 · 0 comments
Open
Assignees

Comments

@KPreisner
Copy link
Member

What?

Modify existing polling termination conditionals to use the new finished_processing attribute: https://sindri.app/docs/reference/api/circuit-detail/#:~:text=JobStatus%20choices-,finished_processing,-Finished%20Processing%20(boolean)

Why?

With the Sindri release v1.14.5, the Circuit/Proof status/detail API endpoint response objects now have the new boolean attribute finished_processing, which the API derives from the status DB field of those objects.

Sindri added this new attribute to their Circuit/Proof record API response schemas to further the separation of concerns from backend to frontend coding details. This allows Sindri clients to know when a Circuit/Proof record is "finished" without needing to know what all of the possible combinations of attributes determine an in-progress vs finished object.

@KPreisner KPreisner self-assigned this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant