Silence unavoidable removal warnings during build & remove getters. (#7346)

* Suppress all removal warnings & remove getters.

* Fix casing.

Author: Moderocky

src/main/java/ch/njol/skript/SkriptConfig.java

@@ -219,6 +219,7 @@ public static String formatDate(final long timestamp) {
 
 	public static final Option<Boolean> apiSoftExceptions = new Option<>("soft api exceptions", false);
 
+	@SuppressWarnings("removal")
 	public static final Option<Boolean> enableTimings = new Option<>("enable timings", false)
 			.setter(t -> {
 				if (!Skript.classExists("co.aikar.timings.Timings")) { // Check for Timings

src/main/java/ch/njol/skript/bukkitutil/HealthUtils.java

@@ -4,6 +4,9 @@
 import ch.njol.util.Math2;
 import java.lang.reflect.Constructor;
 import java.lang.reflect.InvocationTargetException;
+
+import org.bukkit.NamespacedKey;
+import org.bukkit.Registry;
 import org.bukkit.attribute.Attributable;
 import org.bukkit.attribute.Attribute;
 import org.bukkit.attribute.AttributeInstance;
@@ -29,7 +32,7 @@ public class HealthUtils {
 	private static final Attribute MAX_HEALTH;
 	static {
 		if (Skript.isRunningMinecraft(1, 21, 3)) { // In 1.21.3, Attribute became an Interface
-			MAX_HEALTH = Attribute.valueOf("MAX_HEALTH");
+			MAX_HEALTH = Registry.ATTRIBUTE.get(NamespacedKey.minecraft("max_health"));
 		} else {
 			MAX_HEALTH = (Attribute) Enum.valueOf((Class) Attribute.class, "GENERIC_MAX_HEALTH");
 		}
@@ -133,6 +136,7 @@ public static void setDamage(EntityDamageEvent event, double damage) {
 			((LivingEntity) event.getEntity()).setLastDamage(damage * 2);
 	}
 
+	@SuppressWarnings("removal")
 	public static void setDamageCause(Damageable damageable, DamageCause cause) {
 		if (OLD_DAMAGE_EVENT_CONSTRUCTOR != null) {
 			try {

src/main/java/ch/njol/skript/bukkitutil/SoundUtils.java

@@ -22,11 +22,11 @@ public final class SoundUtils {
 	 * @param soundString The enum name to use to find the sound.
 	 * @return The key of the sound.
 	 */
+	@SuppressWarnings("removal")
 	public static @Nullable NamespacedKey getKey(String soundString) {
 		soundString = soundString.toUpperCase(Locale.ENGLISH);
 		if (SOUND_IS_INTERFACE) {
 			try {
-				//noinspection deprecation,removal
 				return Sound.valueOf(soundString).getKey();
 			} catch (Exception ignored) {}
 		} else {
@@ -44,9 +44,9 @@ public final class SoundUtils {
 	 * @param sound The sound to get the key string of.
 	 * @return The key string of the {@link NamespacedKey} of the sound.
 	 */
+	@SuppressWarnings("removal")
 	public static @NotNull NamespacedKey getKey(Sound sound) {
 		if (SOUND_IS_INTERFACE) {
-			//noinspection deprecation,removal
 			return sound.getKey();
 		} else {
 			return ((Keyed) sound).getKey();

src/main/java/ch/njol/skript/classes/SerializableGetter.java

@@ -2,8 +2,6 @@
 
 import ch.njol.skript.util.Getter;
 
-/**
- * @author Peter Güttinger
- */
-@Deprecated
+@Deprecated(forRemoval = true)
+@SuppressWarnings("removal")
 public abstract class SerializableGetter<R, A> extends Getter<R, A> {}

src/main/java/ch/njol/skript/command/Commands.java

@@ -82,7 +82,7 @@ public static SimpleCommandMap getCommandMap(){
 		return commandMap;
 	}
 
-	@SuppressWarnings("unchecked")
+	@SuppressWarnings({"unchecked", "removal"})
 	private static void init() {
 		try {
 			if (Bukkit.getPluginManager() instanceof SimplePluginManager) {

src/main/java/ch/njol/skript/effects/EffHidePlayerFromServerList.java

@@ -56,11 +56,12 @@ public boolean init(Expression<?>[] exprs, int matchedPattern, Kleenean isDelaye
 	}
 
 	@Override
+	@SuppressWarnings("removal")
 	protected void execute(Event e) {
 		if (!(e instanceof ServerListPingEvent))
 			return;
 
-		Iterator<Player> it = ((ServerListPingEvent) e).iterator();		
+		Iterator<Player> it = ((ServerListPingEvent) e).iterator();
 		Iterators.removeAll(it, Arrays.asList(players.getArray(e)));
 	}
 
@@ -69,4 +70,4 @@ public String toString(@Nullable Event e, boolean debug) {
 		return "hide " + players.toString(e, debug) + " from the server list";
 	}
 
-}
+}