Skip to content

Commit a244db1

Browse files
Apply suggestions from code review
Co-authored-by: cheeezburga <47320303+cheeezburga@users.noreply.github.com>
1 parent 371c3d8 commit a244db1

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

src/main/java/ch/njol/skript/classes/data/DefaultFunctions.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -661,7 +661,7 @@ public Quaternionf[] executeSimple(Object[][] params) {
661661
return CollectionUtils.array(new Quaternionf(x, y, z, w));
662662
}
663663
})
664-
.description("Returns a quaternion from the given w, x, y and z parameters. ")
664+
.description("Returns a quaternion from the given W, X, Y and Z parameters. ")
665665
.examples("quaternion(1, 5.6, 45.21, 10)")
666666
.since("INSERT VERSION");
667667
}

src/main/java/ch/njol/skript/expressions/ExprXYZComponent.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@
2020

2121
import java.util.Locale;
2222

23-
@Name("Vector/Quaternion - XYZ Component")
23+
@Name("Vector/Quaternion - WXYZ Component")
2424
@Description({
25-
"Gets or changes the X, Y or Z component of <a href='classes.html#vector'>vectors</a>/<a href='classes.html#quaternion'>quaternions</a>.",
25+
"Gets or changes the W, X, Y or Z component of <a href='classes.html#vector'>vectors</a>/<a href='classes.html#quaternion'>quaternions</a>.",
2626
"You cannot use the W component with vectors; it is for quaternions only."
2727
})
2828
@Examples({

src/main/java/org/skriptlang/skript/bukkit/misc/effects/EffRotate.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,15 +27,15 @@
2727

2828
@Name("Rotate")
2929
@Description({
30-
"Rotates Displays, Quaternions, or Vectors around an axis a set amount of degrees, or around all 3 axes at once.",
30+
"Rotates displays, quaternions, or vectors around an axis a set amount of degrees, or around all 3 axes at once.",
3131
"Vectors can only be rotated around the global X/Y/Z axes, or an arbitrary vector axis.",
32-
"Quaternions are more flexible, allowing rotation around the global or local X/Y/Z axes, arbitrary vectors, or all 3 local axis at once.",
32+
"Quaternions are more flexible, allowing rotation around the global or local X/Y/Z axes, arbitrary vectors, or all 3 local axes at once.",
3333
"Global axes are the ones in the Minecraft world. Local axes are relative to how the quaternion is already oriented.",
3434
"",
3535
"Rotating a display is a shortcut for rotating its left rotation. If the right rotation needs to be modified, it should be acquired, rotated, and re-set.",
3636
"",
3737
"Note that rotating a quaternion/display around a vector results in a rotation around the local vector, so results may not be what you expect. " +
38-
"For example, rotating quaternions/displays around vector(1, 0, 0) is the same as rotating around the local x axis.",
38+
"For example, rotating quaternions/displays around vector(1, 0, 0) is the same as rotating around the local X axis.",
3939
"The same applies to rotations by all three axes at once. " +
4040
"In addition, rotating around all three axes of a quaternion/display at once will rotate in ZYX order, meaning the Z rotation will be applied first and the X rotation last."
4141
})

src/test/skript/tests/syntaxes/expressions/ExprXYZComponent.sk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ test "vector xyz":
3030
assert the x component of {_v::*} is (-1.5, -1.5, and -1.5) with "x component of multiple vectors failed"
3131
assert the y component of {_v::*} is (2, 3, and 4) with "changing x component of multiple vectors changed y components too"
3232

33-
test "quaternion xyz" when running minecraft "1.19.4":
33+
test "quaternion wxyz" when running minecraft "1.19.4":
3434
assert the w component of quaternion(1, 0, 0, 0) is 1 with "w vector component failed"
3535
assert the x component of quaternion(1, 0, 0, 0) is 0 with "x vector component failed"
3636
assert the y component of quaternion(1, 0, 0, 0) is 0 with "y vector component failed"

0 commit comments

Comments
 (0)