From b78559155a4a08314507fe7b5ca7ea7b501e3c73 Mon Sep 17 00:00:00 2001
From: cheeezburga <47320303+cheeezburga@users.noreply.github.com>
Date: Fri, 4 Oct 2024 07:24:12 +1000
Subject: [PATCH] Fixes 5804-is-burning regression test (#7124)

* Fixes 5804-is-burning regression test
- Previously used a wait to allow the pig's fire ticks to update, but waits aren't allowed in tests, so now just uses the ignite effect

* Suggestions

Co-authored-by: Efy <35348263+Efnilite@users.noreply.github.com>

---------

Co-authored-by: Efy <35348263+Efnilite@users.noreply.github.com>
---
 .../tests/regressions/5804-is-burning.sk      | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

diff --git a/src/test/skript/tests/regressions/5804-is-burning.sk b/src/test/skript/tests/regressions/5804-is-burning.sk
index d3e01711dc6..ea4be008393 100644
--- a/src/test/skript/tests/regressions/5804-is-burning.sk
+++ b/src/test/skript/tests/regressions/5804-is-burning.sk
@@ -1,9 +1,14 @@
+# This test is to see if the `is burning` condition works properly.
+# Before, something like `if {x} is burning` would try to compare {x} to the burning damage cause
+# instead of whether or not the entity was burning.
 test "burning":
-	spawn a pig at event-location
-	set {_pig} to the last spawned pig
+	spawn a pig at event-location:
+		set {_pig} to entity
+
 	assert "burning" parsed as damage cause is burning with "burning damage cause compare"
-	set burning time of {_pig} to 9000 ticks
-	wait a tick
-	assert entity within {_pig} is burning with "is burning failed"
-	assert {_pig} is burning with "is burning failed ##2"
-	clear entity within {_pig}
+
+	ignite {_pig}
+	assert entity within {_pig} is burning with "entity within is burning failed"
+	assert {_pig} is burning with "is burning failed"
+
+	delete entity within {_pig}