Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add potion related events #5126

Open
1 task done
Fusezion opened this issue Sep 29, 2022 · 0 comments
Open
1 task done

Add potion related events #5126

Fusezion opened this issue Sep 29, 2022 · 0 comments
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).

Comments

@Fusezion
Copy link
Contributor

Fusezion commented Sep 29, 2022 •
edited
Loading

Suggestion

Add potion related events and actions to skript

Potions

1.12+ PotionSplashEvent
1.12+ LingeringPotionSplashEvent
1.13+ EntityPotionEffectEvent

Witch Potions

Paper 1.12+ WitchConsumePotionEvent
Paper 1.12+ WitchReadyPotionEvent
Paper 1.12+ WitchThrowPotionEvent

Why?

Not currently supported

Other

I'm unsure whether it's worth creating a PR for this now or waiting for #4183 to be merged
knowing this will take a long time being dependent on the module system and all

The downside of adding it now is that we'd have to still have to update #4183 in the future when planning to merge it

Agreement

  • I have read the guidelines above and affirm I am following them with this suggestion.
@AyhamAl-Ali AyhamAl-Ali added enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements). labels Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AyhamAl-Ali @Fusezion