Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ExprSortedList and ExprShuffledList a WrapperExpression #7635

Open
1 task done
TheLimeGlass opened this issue Feb 21, 2025 · 3 comments
Open
1 task done

Make ExprSortedList and ExprShuffledList a WrapperExpression #7635

TheLimeGlass opened this issue Feb 21, 2025 · 3 comments

Comments

@TheLimeGlass
Copy link
Contributor

TheLimeGlass commented Feb 21, 2025

Suggestion

Make ExprSortedList and ExprShuffledList a WrapperExpression so that any addon can read the expression as a WrapperExpression and get the original expression before manipulation.

Should have been this way when the class was made because it falls under the definition of the WrapperExpression.

Agreement

  • I have read the guidelines above and affirm I am following them with this suggestion.
@Pikachu920
Copy link
Member

I would disagree that these are wrappers

@sovdeeth
Copy link
Member

I also am unsure how these are wrappers. They're completely transformed values from the input, they do not reference the original for information.

@TheLimeGlass
Copy link
Contributor Author

It would be useful information for say an addon to use the source() method of the expression to get the original list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants