Skip to content

EntityBlockStorage + Beehive #7316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Mar 16, 2025
Merged

EntityBlockStorage + Beehive #7316

merged 24 commits into from
Mar 16, 2025

Conversation

Absolutionism
Copy link
Contributor

@Absolutionism Absolutionism commented Dec 27, 2024 •
edited
Loading

Description

This PR aims to add support for EntityBlockStorage. Allowing users to add entities into an entity block storage such as beehives, release the stored entities, clear the stored entities (Paper) and get the current + max entity count.
As well as support for Beehives such as target flower and honey level.

Target Minecraft Versions: any
Requirements: none
Related Issues: none

Moderocky
Moderocky reviewed Dec 27, 2024
View reviewed changes
Efnilite
Efnilite requested changes Dec 27, 2024
View reviewed changes
@Efnilite Efnilite added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Dec 27, 2024
ShaneBeee
ShaneBeee suggested changes Dec 27, 2024
View reviewed changes
ShaneBeee
ShaneBeee suggested changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@ShaneBeee ShaneBeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple minor things

ShaneBeee
ShaneBeee suggested changes Dec 28, 2024
View reviewed changes
Copy link
Contributor

@ShaneBeee ShaneBeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just one little nit pick

ShaneBeee
ShaneBeee approved these changes Dec 28, 2024
View reviewed changes
Copy link
Contributor

@ShaneBeee ShaneBeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is my approval for fun 👍

sovdeeth
sovdeeth requested changes Dec 28, 2024
View reviewed changes
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syntax comments

sovdeeth
sovdeeth requested changes Dec 28, 2024
View reviewed changes
sovdeeth
sovdeeth requested changes Dec 30, 2024
View reviewed changes
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks pretty good

@Efnilite Efnilite added feature Pull request adding a new feature. and removed enhancement Feature request, an issue about something that could be improved, or a PR improving something. labels Dec 31, 2024
sovdeeth
sovdeeth requested changes Dec 31, 2024
View reviewed changes
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some edge cases, everything else looks good

Efnilite
Efnilite requested changes Dec 31, 2024
View reviewed changes
sovdeeth
sovdeeth requested changes Jan 8, 2025
View reviewed changes
@Absolutionism Absolutionism requested a review from sovdeeth January 9, 2025 20:07
@Efnilite Efnilite added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Mar 15, 2025
@sovdeeth sovdeeth merged commit 5bcbd80 into SkriptLang:dev/feature Mar 16, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sovdeeth sovdeeth sovdeeth approved these changes

@ShaneBeee ShaneBeee ShaneBeee approved these changes

@Efnilite Efnilite Efnilite approved these changes

@Moderocky Moderocky Awaiting requested review from Moderocky

Assignees
No one assigned
Labels
feature Pull request adding a new feature. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Absolutionism @sovdeeth @Moderocky @ShaneBeee @Efnilite