Skip to content

Commit df28021

Browse files
rupertnashjcfrlassoan
committed
BUG: vtkMacroKitPythonWrap: Remove unnecessary link against VTK_PYTHON_LIBRARIES
Since the variable VTK_WRAP_PYTHON_FIND_LIBS was removed in Kitware/VTK@ed49fa01c (VTK v9.0.0) but is still used in VTK v8.2.0, this commit conditionally set it. Similarly it removes the link against VTK_PYTHON_LIBRARIES as any necessary link should be picked up via the INTERFACE_LINK property of VTK::Python. Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com> Co-authored-by: Andras Lasso <lasso@queensu.ca>
1 parent 84c1a4d commit df28021

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

CMake/vtkMacroKitPythonWrap.cmake

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,8 +160,10 @@ macro(vtkMacroKitPythonWrap)
160160

161161
if(VTK_WRAP_PYTHON AND BUILD_SHARED_LIBS)
162162

163+
if (${VTK_VERSION} VERSION_LESS "8.90")
163164
# Tell vtkWrapPython.cmake to set VTK_PYTHON_LIBRARIES for us.
164165
set(VTK_WRAP_PYTHON_FIND_LIBS 1)
166+
endif()
165167
include(vtkWrapPython)
166168

167169
set(TMP_WRAP_FILES ${MY_KIT_SRCS} ${MY_KIT_WRAP_HEADERS})
@@ -344,7 +346,6 @@ macro(vtkMacroKitPythonWrap)
344346
target_link_libraries(${MY_KIT_NAME}Python
345347
PRIVATE
346348
${MY_KIT_NAME}
347-
${VTK_PYTHON_LIBRARIES}
348349
VTK::WrappingPythonCore
349350
VTK::Python
350351
)

0 commit comments

Comments
 (0)