Skip to content

Profile plot - options for additional variables on secondary y-axis and/or color ramp #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dshean opened this issue Jan 6, 2025 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@dshean
Copy link
Member

dshean commented Jan 6, 2025

Currently, when a user selects multiple variables for the profile plot, a secondary y axis is created, but the new points use the same marker color/style, which makes interpretation challenging.
SlideRule Client 2025-01-06 09-23-16

We should probably limit the profile plot to just two variables, as when 3 or more are selected, the secondary y-axis labels become challenging to interpret.

At a minimum, each variable plotted should have a unique color and marker (circle, square, etc).

An alternative approach is to use point color to show the secondary values. So we would use the same points on the x_atc vs. h_mean axes, but change marker color (with new color ramp legend) to reflect the secondary n_fit_photons (or whatever is selected). I'm not sure how challenging this would be with the plotting libraries - it is straightforward using geopandas choropleth. If you point me to relevant docs, I can do some research on what is possible.

This ties into the issue about how to handle multiple spot/rgt/cycle on the same profile plot. I think a larger discussion with the team around how we can use solid colors, marker type, marker size, and any color ramps to visualize all of this information is needed.

Build Information
Build Date: 2025-01-05 11:00:06
Build Env: v1.3.2-0-g3c53e48
Version: v1.3.2
Navigator/User Agent Information
Online Status: Online
Browser: Firefox
Operating System: MacOS
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:133.0) Gecko/20100101 Firefox/133.0
Language: en-US

@dshean dshean added the enhancement New feature or request label Jan 6, 2025
@dshean
Copy link
Member Author

dshean commented Jan 6, 2025

After reviewing ATL03 photon classification plotting...

For all profile plots, I think we may want to have a way for the user to specify the variable to use for the y-axis values (e.g., height) and a variable to use for the marker color (e.g., yapc_score) which will be displayed with a color ramp or predefined colors (like ATL08 class). By default, we can assume that these will be the same.

Need to think about this a bit more, and iterate on what is possible.

@dshean
Copy link
Member Author

dshean commented Jan 7, 2025

Adding note to also offer selection of variable to display in map

@dshean
Copy link
Member Author

dshean commented Jan 7, 2025

To summarize, I think the following might work well...
Map panel: dropdown to select variable for point color (e.g., h_mean)
Profile plot: dropdown to select variable for y-axis values (e.g., h_mean), second dropdown to select variable for point color (e.g., h_sigma).
If ATL03 selected, second dialog to the right below profile, with similar structure, one dropdown to select y-axis value (e.g., height), second dropdown to select the variable for point color (e.g., yapc)

In terms of color ramp selection and limits (min, max), I think we could offer "linked" (shared values for both map and profile) or independent definitions. The independent approach allows flexibility to select different point color options, like solid color, color ramp, or predefined classes.

@cugarteblair cugarteblair self-assigned this Jan 14, 2025
cugarteblair added a commit that referenced this issue Jan 17, 2025
@cugarteblair
Copy link
Contributor

most of this was done in fixed in v1.4.0.

@cugarteblair
Copy link
Contributor

see #253 for feature still pending

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants