Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Liscon NFT tokens metadata #215

Open
oleggrib opened this issue Dec 6, 2021 · 23 comments
Open

Generate Liscon NFT tokens metadata #215

oleggrib opened this issue Dec 6, 2021 · 23 comments
Assignees

Comments

@oleggrib
Copy link
Collaborator

oleggrib commented Dec 6, 2021

Minting Contract code - https://github.com/TokenScript/attestation/blob/b545e1a640e3623206b24bdd76f9ba4f95879296/ethereum/attestation-test/contracts/AttestationMintable.sol
Contract address - 0xd2336c95896f8165D9e46Db4671d83ceA90C87F3
Network - Rinkeby
tokenURI() according to the rules: https://github.com/AlphaWallet/AlchemyNFT/blob/main/docs/PERMALINKS.md (in the contract code its different, but updated after contract deployed)
@JamesSmartCell , can you, please, update tokenURI() in the contract?

@foxgem , can you help with listen for that contract events and generate NFT metadata? After testing we will deploy same contract to the multiple networks and have to listen for them too.

@tomek, can you create image template and metadata content for the Liscon NFT ?
content example:
{
"name":"...."
"description":"....",
"image":"image_will_be_pregenerated_from_template_by_ticketID",
"attributes":[]
}

@AW-STJ , can you check if Tomek tagged correctly? (github doesnt autofill Tomek, maybe he is not asigned to that repo)

@hboon
Copy link
Member

hboon commented Dec 6, 2021

@oleggrib it's @colourfreak

@oleggrib
Copy link
Collaborator Author

oleggrib commented Dec 6, 2021

@oleggrib it's @colourfreak

Thank you, but @colourfreak is not in this repo contributors list.

@foxgem
Copy link
Collaborator

foxgem commented Dec 6, 2021

@foxgem , can you help with listen for that contract events and generate NFT metadata? After testing we will deploy same contract to the multiple networks and have to listen for them too.

please confirm my understanding about business is right:

  1. the trigger is: mintUsingAttestation, if the passed attestation is valid, a ticket is minted.
  2. then transfer event will be emitted.

what we need to do: listening for the transfer event and then generating the metadata / image in the event handler.

what we need:

  1. metadata template for each token minted.
  2. image template
  3. if a contract metadata is required, the template for it also have to be given.

btw, what repo will we use? I personally think this requirement is a project specific, shouldn't we open this issue in a project github repo?

@oleggrib
Copy link
Collaborator Author

oleggrib commented Dec 6, 2021

@foxgem , yes, correct.
trigger is mintUsingAttestation, if attestation valid then token minted and event Transfer( 0, address) created.

btw, what repo will we use? I personally think this requirement is a project specific, shouldn't we open this issue in a project github repo?

@colourful-land , can you decide ?

@JamesSmartCell
Copy link
Contributor

Liscon test contract is updated on Rinkeby here: 0x74D2769a4092A021C7A47b7d3e4E2ACa75C4c7de

This contract has the updated Token URI

@AW-STJ
Copy link
Contributor

AW-STJ commented Dec 7, 2021

@foxgem

  1. metadata template for each token minted.

Can you share the templates that you might have used for AutographNFT, including the metadata template for REMIX Token as well as contract metadata template (or links would be helpful)

  1. image template

Would this design be enough to create the Liscon NFT ticket image generator:
https://app.zeplin.io/project/5fe1c9ddd9d426343ebdf912/screen/61a888cc9cc73c9f543695c4

  1. if a contract metadata is required, the template for it also have to be given.

I will do it. Please share the templates if you have it.

btw, what repo will we use? I personally think this requirement is a project specific, shouldn't we open this issue in a project github repo?

That is correct. Which repo did we use for Liscon? Ideally we should have this ticket under that repo rather than in attestation repo.

@foxgem
Copy link
Collaborator

foxgem commented Dec 7, 2021

@AW-STJ

example metadata links:

That is correct. Which repo did we use for Liscon? Ideally we should have this ticket under that repo rather than in attestation repo.

@oleggrib can you help this?

@oleggrib
Copy link
Collaborator Author

oleggrib commented Dec 7, 2021

https://github.com/TokenScript/LisCon
we use this repo to auto-deploy LisCon files to the hosting

@colourfreak
Copy link

@tomek, can you create image template and metadata content for the Liscon NFT ?
content example:
{
"name":"...."
"description":"....",
"image":"image_will_be_pregenerated_from_template_by_ticketID",
"attributes":[]
}

No idea what do you want me to do. I need more context, more explanation. What do I have to do with the above data? Image template? What do you mean by this? Example, simple sketch or drawing would be helpful.

@oleggrib
Copy link
Collaborator Author

oleggrib commented Dec 9, 2021

@colourfreak , we need some creative template of Liscon NFT metadata in the next example format:

{
"name":"Proof of presence at Liscon Conference #222839947262873898129289"
"description":"The NFT is unique for each Liscon Conference Ticket, ensures participation in conference at Oct 20-21, 2021, Lisbon ...",
"image":"image_will_be_pregenerated_from_template_by_ticketID",
"attributes":[
    conference: "...",
    date: "..."
    ...
]}

maybe worth to add attributes, like in example.

@colourfreak
Copy link

Do you mean the same info in the different background? @oleggrib

@colourfreak
Copy link

what is the use of it? In which context? What is the size of it?

@colourfreak
Copy link

I still don't understand it.

@oleggrib
Copy link
Collaborator Author

oleggrib commented Dec 9, 2021

what is the use of it? In which context? What is the size of it?

size is up to you. It will be Liscon Ticket metadata. It will be visible in OpenSea and other marketplaces. You can see similar data for any NFT in OpenSea,

this is example metadata from autographnft.io
image

{"name":"Colors","description":null,"image":"https://rinkeby.alchemynft.io/upload/0xf52da9e1fd0a032c4b13659a18fff5a03a211a62395d3cb2ecbe29bfd9a889f4-1629999188513.png","attributes":[],"external_url":"https://testnet.autographnft.io/0x0000853abe6fa93f276b62f6984b75ff2f9dc30e/204/make-offer/"}

but this one contains empty description and attributes

@colourfreak
Copy link

Not sure why it's me who is doing this. It does not look like UI work. I can try, but let me learn in which language this is written. XML?

@oleggrib
Copy link
Collaborator Author

oleggrib commented Dec 9, 2021

basically we need nice-looking creative

  1. tokenName
  2. tokenDescription
  3. maybe some creative attributes list

dont care about format, we just need data. cc @AW-STJ , does @colourfreak have to do it?

@colourfreak
Copy link

colourfreak commented Dec 9, 2021

@AW-STJ It's not my job. I don't have any experience in writing metadata. "Experience": null; It will take time till I will learn JSON. I could cook Hungarian national soup with no experience and it would be the same journey for me. Learn then build.

@colourfreak
Copy link

"Description": "LisCon is a celebration of our culture and values, a coming together of builders, thinkers and creators across the space"
"Package": "Full"
"ID": "244"
"Type": "Physical"

@colourfreak
Copy link

Again, I am not a right person to do this task. I don't know much about Liscon, I don't know JSON. Sorry.

@AW-STJ
Copy link
Contributor

AW-STJ commented Dec 9, 2021

@AW-STJ It's not my job. I don't have any experience in writing metadata. "Experience": null; It will take time till I will learn JSON. I could cook Hungarian national soup with no experience and it would be the same journey for me. Learn then build.

Hey @colourfreak - I will take care of the metadata. However, thank you for taking the journey of learning and attempting to get the job done with what you have. Love the spirit.

@AW-STJ
Copy link
Contributor

AW-STJ commented Dec 9, 2021

Hey @oleggrib - this should work for now right?

"name":"LisCon 2021 Ticket #222839947262873898129289"
"description":"LisCon is a celebration of our culture and values, a coming together of builders, thinkers and creators across the space. This NFT is the token avatar of original ticket, minted by the ticket holder after the event",
"image":"image_will_be_pregenerated_from_template_by_ticketID",
"attributes":[
    Year: "2021",
    ]} 

@AW-STJ
Copy link
Contributor

AW-STJ commented Dec 17, 2021

The feedback for the current version of ticket minting.

  1. The user have to connect to Metamask again. Can we skip this step of connected to Wallet twice?

image

  1. There is no loading screen and then success message to show to the user that the minting process is underway. I had to refresh the screen to get the NFT minted screen below. Can we do the process like how AutographNFT behaves right now.
    image

Will share more feedback a I test further.

@oleggrib
Copy link
Collaborator Author

@AW-STJ , I have added notifications pop-up and centered attestation.id iframe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants