From 087a3c38e1d8fc5924dc2510a8ef1e71331bd001 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jarek=20Krupi=C5=84ski?= Date: Wed, 5 Apr 2023 10:57:17 +0200 Subject: [PATCH 1/3] #97289 - Fix mage error styles --- .../product/view/type/options/configurable.phtml | 1 + .../components/Molecules/form/select/_select.scss | 10 ++++++++++ .../Organisms/quantity-update/_quantity-update.scss | 1 + .../product-view/_product-view-variables.scss | 2 +- 4 files changed, 13 insertions(+), 1 deletion(-) diff --git a/Magento_ConfigurableProduct/templates/product/view/type/options/configurable.phtml b/Magento_ConfigurableProduct/templates/product/view/type/options/configurable.phtml index 710a6e645..134dde510 100644 --- a/Magento_ConfigurableProduct/templates/product/view/type/options/configurable.phtml +++ b/Magento_ConfigurableProduct/templates/product/view/type/options/configurable.phtml @@ -12,6 +12,7 @@ $_attributes = $block->decorateArray($block->getAllowAttributes()); class=" select select--native + select--grid field configurable required diff --git a/Snowdog_Components/components/Molecules/form/select/_select.scss b/Snowdog_Components/components/Molecules/form/select/_select.scss index fa95bcdb4..5ebba2ce8 100644 --- a/Snowdog_Components/components/Molecules/form/select/_select.scss +++ b/Snowdog_Components/components/Molecules/form/select/_select.scss @@ -86,6 +86,10 @@ } } + &--grid { + display: grid; + } + &__button { flex-shrink: 0; margin: $spacer--medium 0 0; @@ -137,6 +141,12 @@ } // select2 overwrite styles +.select2-hidden-accessible { + & + .mage-error { + order: 1; + } +} + .select2 { width: 100%; } diff --git a/Snowdog_Components/components/Organisms/quantity-update/_quantity-update.scss b/Snowdog_Components/components/Organisms/quantity-update/_quantity-update.scss index 003f75eb0..5105e5de6 100644 --- a/Snowdog_Components/components/Organisms/quantity-update/_quantity-update.scss +++ b/Snowdog_Components/components/Organisms/quantity-update/_quantity-update.scss @@ -110,6 +110,7 @@ } div.mage-error { + position: absolute; bottom: $quantity-update__mage-error-bottom; width: $quantity-update__mage-error-width; order: 4; diff --git a/Snowdog_Components/components/Templates/product-view/_product-view-variables.scss b/Snowdog_Components/components/Templates/product-view/_product-view-variables.scss index 1d149d4f3..266df8573 100644 --- a/Snowdog_Components/components/Templates/product-view/_product-view-variables.scss +++ b/Snowdog_Components/components/Templates/product-view/_product-view-variables.scss @@ -155,7 +155,7 @@ $product-view__update-requisition-list-width : 100% !default; $product-view__update-requisition-list-button-width : 100% !default; // qty -$product-view__qty-margin : 0 0 $spacer--semi-medium !default; +$product-view__qty-margin : 0 0 $spacer--large !default; // stock status $product-view__stock-status-margin : $spacer--medium 0 0 0 !default; From e20d95d134ec96c8e55d8d42d49c71308e076b86 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jarek=20Krupi=C5=84ski?= Date: Wed, 5 Apr 2023 10:59:55 +0200 Subject: [PATCH 2/3] #97289 - Update changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index b0e7ef661..8a0d63bc0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,7 @@ USE GITHUB ISSUE/PULL REQUEST NUMBERS, NOT INTERNAL ONE ### Added ### Changed ### Fixed +- Mage error styles on PDP (#581) ### Removed ### Updated From b3a1b79c351d560c1a92902c46a937fc3bb41a47 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jarek=20Krupi=C5=84ski?= Date: Thu, 6 Apr 2023 12:58:00 +0200 Subject: [PATCH 3/3] Bump 2.28.4 --- CHANGELOG.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8a0d63bc0..915033d94 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,12 +8,15 @@ USE GITHUB ISSUE/PULL REQUEST NUMBERS, NOT INTERNAL ONE ### Added ### Changed ### Fixed -- Mage error styles on PDP (#581) ### Removed ### Updated ## [Released] +## [2.28.4] - 2023-04-06 +### Fixed +- Mage error styles on PDP (#581) + ## [2.28.3] - 2023-03-31 ### Added - Added styles and templates for MageMe_WebForms (old VladimirPopov_WebForms) module (#575)