From 8ce659c900ffbd12fbcef6ced6400b70db19ff2b Mon Sep 17 00:00:00 2001 From: Aerocatia Date: Wed, 21 Aug 2024 12:37:50 +1200 Subject: [PATCH] Do not default EAX to on when running on Windows versions with hardware EAX Bad sound drivers can cause a BSOD --- src/chimera/chimera.cpp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/chimera/chimera.cpp b/src/chimera/chimera.cpp index 5931db73..fd84ca97 100644 --- a/src/chimera/chimera.cpp +++ b/src/chimera/chimera.cpp @@ -1,6 +1,7 @@ // SPDX-License-Identifier: GPL-3.0-only #include +#include #include #include #include @@ -183,8 +184,11 @@ namespace Chimera { // No more updates enable_block_update_check(); - // Make the game use max settings as default because it's not 2003 anymore - set_up_sane_defaults(); + // Make the game use max settings as default because it's not 2003 anymore (except when it is) + // Defaulting EAX to on is not safe on Windows XP, bad drivers can cause a BSOD. + if(IsWindowsVistaOrGreater()) { + set_up_sane_defaults(); + } // Prevent some annoying registry checks that just make the game slower remove_registry_checks();