Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manual images unusable in dark mode #10

Open
garfieldnate opened this issue Apr 23, 2024 · 1 comment
Open

manual images unusable in dark mode #10

garfieldnate opened this issue Apr 23, 2024 · 1 comment
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@garfieldnate
Copy link
Collaborator

For example:

image

SVG can have CSS in it, so it is possible to change the colors based on whether the user has dark mode activated or not.

For now, users can just switch to light mode to view the images.

@garfieldnate garfieldnate added bug Something isn't working documentation Improvements or additions to documentation labels Apr 23, 2024
@garfieldnate
Copy link
Collaborator Author

For future reference, I would like to use SVG styling similar to the following to change the image colors in dark/light mode:

<style>
    path {
      stroke: "#000000";
    }
    @media ( prefers-color-scheme: dark ) {
      path {
        stroke: #FFFFFF;
      }
    }
  </style>

I've found that this can't simply be dragged and dropped into the SVG files, though, because they use more complex styles that are inline.

I believe that the text in the images has also been translated to path strokes instead of plain <text> elements, which is not ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant