Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix device display bug I introduced #25

Open
thoyt opened this issue Oct 23, 2014 · 3 comments
Open

Fix device display bug I introduced #25

thoyt opened this issue Oct 23, 2014 · 3 comments

Comments

@thoyt
Copy link
Member

thoyt commented Oct 23, 2014

In actuator display, sometimes we want to display the end of the path, sometimes the parent level. In the case of "on" display the device name

@thoyt
Copy link
Member Author

thoyt commented Oct 24, 2014

Actually maybe this is the right way to do it. What do you think, @gtfierro ? In the lighting zone page, it doesn't display "on" but the lighting group name. This is probably better, since it's currently the only way to differentiate between the groups.

@thoyt
Copy link
Member Author

thoyt commented Oct 24, 2014

Oops, hadn't committed this before that comment.. see 2074df4

@gtfierro
Copy link
Member

Works for me, but we also could have just added the group name to the header of that section.

The issue with pulling names out of the paths is not one that should exist. We should really have a way of querying the metadata to get all streams that belong to a certain device.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants