[Bug]: direct_replier.py sample is broken

[TrentDaniel]

Bug Description

• Line 27 has a an improper comparison to None with request.get_payload_as_string() != None
• Line 41 references a variable outbound_msg_builder when no variable under that name has been instantiated

Expected Behavior

• Line 27, the comparison should be written as request.get_payload_as_string() is not None
• Line 41, instead of referencing outbound_msg_builder, self.message_builder should be referenced

Steps to Reproduce

Reproduction not required, just look at source.

Solace Product

Solace APIs

Solace Broker version

sample issue, not relevant

Solace API

sample issue, not relevant

Solace API version

sample issue, not relevant

[TamimiGitHub]

Hey @TrentDaniel - just getting to this. A couple of comments

• I just ran the replier and requester and was able run the sample with no issue

python direct_replier.py
python direct_requestor.py

• Can you elaborate further on why the improper comparison to None? It woks with the comparison, but I can change it to is not for python convention
• I'm still not sure why we should use self.message_builder instead of referencing outbound_msg_builder