Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
SC-4361 Update sonar-scanner-cli to v4.8 (#47)
- Loading branch information
1 parent
cb201f3
commit db50107
db50107There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That change does not seem to have been tested: node.js 12 is used in the image and is deprecated in GitHub actions.
Using v1.8 make sonar-scanner GitHub action works again.
db50107There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They've pushed a buggy image just recently, older 4.8 worked fine.
https://github.com/SonarSource/sonar-scanner-cli-docker/issues/171
db50107There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@antonio-garcia-sonarsource ping :)
https://community.sonarsource.com/t/sonarsource-sonarcloud-github-action-failing-with-node-js-12-error/89664/16
db50107There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've fixed with specifying the previous version for now:
Note to Sonar: why can't we flag issues in your repo? It would help us out a lot!
db50107There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://community.sonarsource.com/t/sonarsource-sonarcloud-github-action-failing-with-node-js-12-error/89664/16