SLVS-1387 Make sure the initial list of projects is restored when the filter is cleared.

It doesn't make sense when the filter is cleared to reload all the projects by asking SlCore, because the chance that the list of projects changed is low. Instead the advantage can be considerable for users that have more than 10.000 projects.

Author: gabriela-trutan-sonarsource

src/ConnectedMode.UnitTests/UI/ProjectSelection/ProjectSelectionViewModelTests.cs

@@ -125,15 +125,16 @@ await progressReporterViewModel.Received(1)
             .ExecuteTaskWithProgressAsync(
                 Arg.Is<TaskToPerformParams<AdapterResponseWithData<List<ServerProject>>>>(x =>
                     x.ProgressStatus == UiResources.SearchingProjectInProgressText &&
-                    x.WarningText == UiResources.SearchingProjectFailedText &&
-                    x.AfterSuccess == testSubject.InitProjects));
+                    x.WarningText == UiResources.SearchingProjectFailedText));
     }
 
     [TestMethod]
-    public void ProjectSearchTerm_WithEmptyTerm_ShouldNotUpdateSearchResult()
+    public void ProjectSearchTerm_WithEmptyTerm_ShouldRestoreInitialListOfProjects()
     {
         var viewModel = CreateInitializedTestSubjectWitNotMockedProgress();
+        slCoreConnectionAdapter.FuzzySearchProjectsAsync(testSubject.ServerConnection, Arg.Any<string>()).Returns(new AdapterResponseWithData<List<ServerProject>>(true, []));
 
+        viewModel.ProjectSearchTerm = "myProject";
         viewModel.ProjectSearchTerm = "";
 
         viewModel.ProjectResults.Should().BeEquivalentTo(AnInitialListOfProjects);
@@ -196,6 +197,34 @@ await progressReporterViewModel.Received(1)
                     x.AfterSuccess == testSubject.InitProjects));
     }
 
+    [TestMethod]
+    public async Task InitializeProjectWithProgressAsync_OnSuccess_CachesInitialServerProjects()
+    {
+        var viewModel = CreateTestSubjectWithNotMockedProgress();
+        MockTrySonarQubeConnection(AConnectionInfo, success: true);
+        var expectedServerProjects = new List<ServerProject> { new("proj1", "name1"), new("proj2", "name2") };
+        slCoreConnectionAdapter.GetAllProjectsAsync(Arg.Any<ServerConnection>())
+            .Returns(new AdapterResponseWithData<List<ServerProject>>(true, expectedServerProjects));
+
+        await viewModel.InitializeProjectWithProgressAsync();
+
+        viewModel.InitialServerProjects.Should().BeEquivalentTo(expectedServerProjects);
+    }
+
+    [TestMethod]
+    public async Task InitializeProjectWithProgressAsync_OnFailure_InitialServerProjectsIsEmpty()
+    {
+        var viewModel = CreateTestSubjectWithNotMockedProgress();
+        MockTrySonarQubeConnection(AConnectionInfo, success: true);
+        var expectedServerProjects = new List<ServerProject> { new("proj1", "name1"), new("proj2", "name2") };
+        slCoreConnectionAdapter.GetAllProjectsAsync(Arg.Any<ServerConnection>())
+            .Returns(new AdapterResponseWithData<List<ServerProject>>(false, expectedServerProjects));
+
+        await viewModel.InitializeProjectWithProgressAsync();
+
+        viewModel.InitialServerProjects.Should().BeEmpty();
+    }
+
     [TestMethod]
     public async Task AdapterGetAllProjectsAsync_GettingServerConnectionSucceeded_CallsAdapterWithCredentialsForServerConnection()
     {
@@ -264,8 +293,13 @@ private void MockTrySonarQubeConnection(ConnectionInfo connectionInfo, bool succ
 
     private ProjectSelectionViewModel CreateInitializedTestSubjectWitNotMockedProgress()
     {
-        var viewModel = new ProjectSelectionViewModel(AConnectionInfo, connectedModeServices, new ProgressReporterViewModel(logger));
+        var viewModel = CreateTestSubjectWithNotMockedProgress();
         viewModel.InitProjects(new AdapterResponseWithData<List<ServerProject>>(true, AnInitialListOfProjects));
         return viewModel;
     }
+
+    private ProjectSelectionViewModel CreateTestSubjectWithNotMockedProgress()
+    { 
+        return new ProjectSelectionViewModel(AConnectionInfo, connectedModeServices, new ProgressReporterViewModel(logger));
+    }
 }

src/ConnectedMode/UI/ProjectSelection/ProjectSelectionViewModel.cs

@@ -63,6 +63,7 @@ public ServerProject SelectedProject
 
     public bool IsProjectSelected => SelectedProject != null;
     public ServerConnection ServerConnection { get; private set; }
+    public List<ServerProject> InitialServerProjects { get; private set; } = [];
 
     private string projectSearchTerm;
     private ServerProject selectedProject;
@@ -93,9 +94,15 @@ internal async Task<AdapterResponseWithData<List<ServerProject>>> AdapterGetAllP
     }
 
     internal void InitProjects(AdapterResponseWithData<List<ServerProject>> response)
+    {
+        FillProjects(response.ResponseData);
+        InitialServerProjects = response.ResponseData;
+    }
+
+    private void FillProjects(List<ServerProject> projects)
     {
         ProjectResults.Clear();
-        foreach (var serverProject in response.ResponseData.OrderBy(p => p.Name))
+        foreach (var serverProject in projects.OrderBy(p => p.Name))
         {
             ProjectResults.Add(serverProject);
         }
@@ -107,6 +114,7 @@ private void SearchForProject()
     {
         if (string.IsNullOrEmpty(ProjectSearchTerm))
         {
+            FillProjects(InitialServerProjects);
             return;
         }
 
@@ -120,7 +128,7 @@ private async Task SearchForProjectWithProgressAsync()
             UiResources.SearchingProjectInProgressText,
             UiResources.SearchingProjectFailedText)
         {
-            AfterSuccess = InitProjects
+            AfterSuccess = response => FillProjects(response.ResponseData)
         };
         await ProgressReporterViewModel.ExecuteTaskWithProgressAsync(initializeProjectsParams);
     }