SLVS-1563 Raise event outside lock block

Author: gabriela-trutan-sonarsource

src/SLCore/State/ActiveConfigScopeTracker.cs

@@ -18,9 +18,7 @@
  * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
  */
 
-using System;
 using System.ComponentModel.Composition;
-using System.Diagnostics;
 using SonarLint.VisualStudio.Core;
 using SonarLint.VisualStudio.Core.Synchronization;
 using SonarLint.VisualStudio.SLCore.Core;
@@ -109,26 +107,26 @@ public void SetCurrentConfigScope(string id, string connectionId = null, string
             {
                 configurationScopeService.DidUpdateBinding(new DidUpdateBindingParams(id, GetBinding(connectionId, sonarProjectKey)));
                 currentConfigScope = currentConfigScope with { ConnectionId = connectionId, SonarProjectId = sonarProjectKey };
-                OnCurrentConfigurationScopeChanged();
-                return;
             }
-
-            configurationScopeService.DidAddConfigurationScopes(new DidAddConfigurationScopesParams([
-                new ConfigurationScopeDto(id, id, true, GetBinding(connectionId, sonarProjectKey))]));
-            currentConfigScope = new ConfigurationScope(id, connectionId, sonarProjectKey);
-            OnCurrentConfigurationScopeChanged();
+            else
+            {
+                configurationScopeService.DidAddConfigurationScopes(new DidAddConfigurationScopesParams([
+                    new ConfigurationScopeDto(id, id, true, GetBinding(connectionId, sonarProjectKey))]));
+                currentConfigScope = new ConfigurationScope(id, connectionId, sonarProjectKey);
+            }
         }
+
+        OnCurrentConfigurationScopeChanged();
     }
 
     public void Reset()
     {
         threadHandling.ThrowIfOnUIThread();
-
         using (asyncLock.Acquire())
         {
             currentConfigScope = null;
-            OnCurrentConfigurationScopeChanged();
         }
+        OnCurrentConfigurationScopeChanged();
     }
 
     public void RemoveCurrentConfigScope()
@@ -150,8 +148,9 @@ public void RemoveCurrentConfigScope()
             configurationScopeService.DidRemoveConfigurationScope(
                 new DidRemoveConfigurationScopeParams(currentConfigScope.Id));
             currentConfigScope = null;
-            OnCurrentConfigurationScopeChanged();
         }
+
+        OnCurrentConfigurationScopeChanged();
     }
 
     public bool TryUpdateRootOnCurrentConfigScope(string id, string root)
@@ -164,9 +163,9 @@ public bool TryUpdateRootOnCurrentConfigScope(string id, string root)
             }
 
             currentConfigScope = currentConfigScope with { RootPath = root };
-            OnCurrentConfigurationScopeChanged();
-            return true;
         }
+        OnCurrentConfigurationScopeChanged();
+        return true;
     }
 
     public bool TryUpdateAnalysisReadinessOnCurrentConfigScope(string id, bool isReady)
@@ -179,9 +178,9 @@ public bool TryUpdateAnalysisReadinessOnCurrentConfigScope(string id, bool isRea
             }
 
             currentConfigScope = currentConfigScope with { isReadyForAnalysis = isReady};
-            OnCurrentConfigurationScopeChanged();
-            return true;
         }
+        OnCurrentConfigurationScopeChanged();
+        return true;
     }
 
     public event EventHandler CurrentConfigurationScopeChanged;