From befc1497f1b446343adfb71a0c0d2a068c2c075f Mon Sep 17 00:00:00 2001
From: Gabriela Trutan <gabriela.trutan@sonarsource.com>
Date: Tue, 24 Sep 2024 10:14:43 +0200
Subject: [PATCH 01/10] SLVS-1448 Improve error message when deleting a
 connection that has no associated project bindings

---
 .../UI/DeleteConnection/DeleteConnectionDialog.xaml   |  2 +-
 .../UI/Resources/UiResources.Designer.cs              | 11 +----------
 src/ConnectedMode/UI/Resources/UiResources.resx       |  5 +----
 3 files changed, 3 insertions(+), 15 deletions(-)

diff --git a/src/ConnectedMode/UI/DeleteConnection/DeleteConnectionDialog.xaml b/src/ConnectedMode/UI/DeleteConnection/DeleteConnectionDialog.xaml
index 092024da0c..6bca2088e1 100644
--- a/src/ConnectedMode/UI/DeleteConnection/DeleteConnectionDialog.xaml
+++ b/src/ConnectedMode/UI/DeleteConnection/DeleteConnectionDialog.xaml
@@ -42,6 +42,7 @@
             <InlineUIContainer Style="{StaticResource ConnectionInfoInlineWrapper}">
                 <ui:ConnectionInfoComponent ConnectionInfo="{Binding ConnectionInfo}" />
             </InlineUIContainer>
+            <Run Text="?" />
         </TextBlock>
         <TextBlock Grid.Row="1"
                    Text="{x:Static res:UiResources.DeleteConnectionNoProjectsLabel}"
@@ -75,7 +76,6 @@
                 <ColumnDefinition Width="*" />
                 <ColumnDefinition Width="*" />
             </Grid.ColumnDefinitions>
-            <TextBlock Grid.Column="0" HorizontalAlignment="Left" Text="{x:Static res:UiResources.AreYouSureConfirmationLabel}" />
             <StackPanel Grid.Column="1" Style="{StaticResource DialogButtonsPanel}">
                 <Button Content="{x:Static res:UiResources.DeleteButton}"
                                    IsDefault="True"
diff --git a/src/ConnectedMode/UI/Resources/UiResources.Designer.cs b/src/ConnectedMode/UI/Resources/UiResources.Designer.cs
index e7eb4e4201..1f51347c68 100644
--- a/src/ConnectedMode/UI/Resources/UiResources.Designer.cs
+++ b/src/ConnectedMode/UI/Resources/UiResources.Designer.cs
@@ -60,15 +60,6 @@ internal UiResources() {
             }
         }
         
-        /// <summary>
-        ///   Looks up a localized string similar to Are you sure?.
-        /// </summary>
-        public static string AreYouSureConfirmationLabel {
-            get {
-                return ResourceManager.GetString("AreYouSureConfirmationLabel", resourceCulture);
-            }
-        }
-        
         /// <summary>
         ///   Looks up a localized string similar to Please fill the authentication details for.
         /// </summary>
@@ -277,7 +268,7 @@ public static string DeleteConnectionBindingsWarningText {
         }
         
         /// <summary>
-        ///   Looks up a localized string similar to You are about to delete the connection to.
+        ///   Looks up a localized string similar to Are you sure you want to delete the connection to.
         /// </summary>
         public static string DeleteConnectionDescription {
             get {
diff --git a/src/ConnectedMode/UI/Resources/UiResources.resx b/src/ConnectedMode/UI/Resources/UiResources.resx
index 6498679539..c661a8a517 100644
--- a/src/ConnectedMode/UI/Resources/UiResources.resx
+++ b/src/ConnectedMode/UI/Resources/UiResources.resx
@@ -285,14 +285,11 @@
   <data name="DeleteConnectionBindingListLabel" xml:space="preserve">
     <value>It is used in the following project bindings:</value>
   </data>
-  <data name="AreYouSureConfirmationLabel" xml:space="preserve">
-    <value>Are you sure?</value>
-  </data>
   <data name="DeleteConnectionNoProjectsLabel" xml:space="preserve">
     <value>It has no associated project bindings</value>
   </data>
   <data name="DeleteConnectionDescription" xml:space="preserve">
-    <value>You are about to delete the connection to</value>
+    <value>Are you sure you want to delete the connection to</value>
   </data>
   <data name="DeleteButton" xml:space="preserve">
     <value>Delete</value>

From 96f095472532e4b70105901a31ed642ea2c117d7 Mon Sep 17 00:00:00 2001
From: Gabriela Trutan <gabriela.trutan@sonarsource.com>
Date: Tue, 24 Sep 2024 11:40:00 +0200
Subject: [PATCH 02/10] SLVS-1448 Add reference to the bindingRepository, which
 is needed to calculate the number of referenced bindings by a server
 connection

---
 .../UI/ConnectedModeBindingServicesTests.cs                 | 4 +++-
 src/ConnectedMode/UI/ConnectedModeBindingServices.cs        | 6 +++++-
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/src/ConnectedMode.UnitTests/UI/ConnectedModeBindingServicesTests.cs b/src/ConnectedMode.UnitTests/UI/ConnectedModeBindingServicesTests.cs
index 61b741097a..7ebf0103e3 100644
--- a/src/ConnectedMode.UnitTests/UI/ConnectedModeBindingServicesTests.cs
+++ b/src/ConnectedMode.UnitTests/UI/ConnectedModeBindingServicesTests.cs
@@ -23,6 +23,7 @@
 using SonarLint.VisualStudio.ConnectedMode.UI;
 using SonarLint.VisualStudio.ConnectedMode.Shared;
 using SonarLint.VisualStudio.ConnectedMode.Binding;
+using SonarLint.VisualStudio.Core.Binding;
 
 namespace SonarLint.VisualStudio.ConnectedMode.UnitTests.UI;
 
@@ -35,6 +36,7 @@ public void MefCtor_CheckIsExported()
         MefTestHelpers.CheckTypeCanBeImported<ConnectedModeBindingServices, IConnectedModeBindingServices>(
             MefTestHelpers.CreateExport<IBindingController>(),
             MefTestHelpers.CreateExport<ISolutionInfoProvider>(),
-            MefTestHelpers.CreateExport<ISharedBindingConfigProvider>());
+            MefTestHelpers.CreateExport<ISharedBindingConfigProvider>(),
+            MefTestHelpers.CreateExport<ISolutionBindingRepository>());
     }
 }
diff --git a/src/ConnectedMode/UI/ConnectedModeBindingServices.cs b/src/ConnectedMode/UI/ConnectedModeBindingServices.cs
index 79e48054c0..0ac2bd1511 100644
--- a/src/ConnectedMode/UI/ConnectedModeBindingServices.cs
+++ b/src/ConnectedMode/UI/ConnectedModeBindingServices.cs
@@ -22,6 +22,7 @@
 using SonarLint.VisualStudio.ConnectedMode.Binding;
 using SonarLint.VisualStudio.ConnectedMode.Shared;
 using SonarLint.VisualStudio.Core;
+using SonarLint.VisualStudio.Core.Binding;
 
 namespace SonarLint.VisualStudio.ConnectedMode.UI;
 
@@ -30,6 +31,7 @@ public interface IConnectedModeBindingServices
     public IBindingController BindingController { get; }
     public ISolutionInfoProvider SolutionInfoProvider { get; }
     public ISharedBindingConfigProvider SharedBindingConfigProvider { get; }
+    public ISolutionBindingRepository SolutionBindingRepository { get; }
 }
 
 [Export(typeof(IConnectedModeBindingServices))]
@@ -38,10 +40,12 @@ public interface IConnectedModeBindingServices
 public class ConnectedModeBindingServices(
     IBindingController bindingController,
     ISolutionInfoProvider solutionInfoProvider,
-    ISharedBindingConfigProvider sharedBindingConfigProvider)
+    ISharedBindingConfigProvider sharedBindingConfigProvider, 
+    ISolutionBindingRepository solutionBindingRepository)
     : IConnectedModeBindingServices
 {
     public IBindingController BindingController { get; } = bindingController;
     public ISolutionInfoProvider SolutionInfoProvider { get; } = solutionInfoProvider;
     public ISharedBindingConfigProvider SharedBindingConfigProvider { get; } = sharedBindingConfigProvider;
+    public ISolutionBindingRepository SolutionBindingRepository { get; } = solutionBindingRepository;
 }

From 08d305a28e8801ee96d8466cdd29b39790194a96 Mon Sep 17 00:00:00 2001
From: Gabriela Trutan <gabriela.trutan@sonarsource.com>
Date: Tue, 24 Sep 2024 13:15:07 +0200
Subject: [PATCH 03/10] SLVS-1448 Add support for calculating a connection
 references

---
 .../ManageConnectionsViewModelTest.cs         | 113 +++++++++++++++++-
 .../ManageConnectionsViewModel.cs             |  42 ++++++-
 .../UI/Resources/UiResources.Designer.cs      |  18 +++
 .../UI/Resources/UiResources.resx             |   6 +
 4 files changed, 175 insertions(+), 4 deletions(-)

diff --git a/src/ConnectedMode.UnitTests/UI/ManageConnections/ManageConnectionsViewModelTest.cs b/src/ConnectedMode.UnitTests/UI/ManageConnections/ManageConnectionsViewModelTest.cs
index 9cba844b50..9dadf07cf0 100644
--- a/src/ConnectedMode.UnitTests/UI/ManageConnections/ManageConnectionsViewModelTest.cs
+++ b/src/ConnectedMode.UnitTests/UI/ManageConnections/ManageConnectionsViewModelTest.cs
@@ -24,6 +24,7 @@
 using SonarLint.VisualStudio.ConnectedMode.UI.ManageConnections;
 using SonarLint.VisualStudio.ConnectedMode.UI.Resources;
 using SonarLint.VisualStudio.Core;
+using SonarLint.VisualStudio.Core.Binding;
 
 namespace SonarLint.VisualStudio.ConnectedMode.UnitTests.UI.ManageConnections;
 
@@ -37,19 +38,22 @@ public class ManageConnectionsViewModelTest
     private IServerConnectionsRepositoryAdapter serverConnectionsRepositoryAdapter;
     private IThreadHandling threadHandling;
     private ILogger logger;
+    private IConnectedModeBindingServices connectedModeBindingServices;
+    private ISolutionBindingRepository solutionBindingRepository;
 
     [TestInitialize]
     public void TestInitialize()
     {
         twoConnections =
         [
-            new Connection(new ConnectionInfo("http://localhost:9000", ConnectionServerType.SonarQube), true),
+            new Connection(new ConnectionInfo("http://localhost:9000/", ConnectionServerType.SonarQube), true),
             new Connection(new ConnectionInfo("myOrg", ConnectionServerType.SonarCloud), false)
         ];
         progressReporterViewModel = Substitute.For<IProgressReporterViewModel>();
         connectedModeServices = Substitute.For<IConnectedModeServices>();
+        connectedModeBindingServices = Substitute.For<IConnectedModeBindingServices>();
 
-        testSubject = new ManageConnectionsViewModel(connectedModeServices, progressReporterViewModel);
+        testSubject = new ManageConnectionsViewModel(connectedModeServices, connectedModeBindingServices, progressReporterViewModel);
 
         MockServices();
     }
@@ -277,6 +281,98 @@ public void CreateNewConnection_ConnectionWasNotAddedToRepository_DoesNotAddConn
         serverConnectionsRepositoryAdapter.Received(1).TryAddConnection(connectionToAdd, Arg.Any<ICredentialsModel>());
     }
 
+    [TestMethod]
+    public async Task GetConnectionReferencesWithProgressAsync_InitializesDataAndReportsProgress()
+    {
+        await testSubject.GetConnectionReferencesWithProgressAsync(new ConnectionViewModel(new Connection(new ConnectionInfo("myOrg", ConnectionServerType.SonarCloud))));
+
+        await progressReporterViewModel.Received(1)
+            .ExecuteTaskWithProgressAsync(
+                Arg.Is<TaskToPerformParams<AdapterResponseWithData<List<string>>>>(x =>
+                    x.ProgressStatus == UiResources.CalculatingConnectionReferencesText &&
+                    x.WarningText == UiResources.CalculatingConnectionReferencesFailedText));
+    }
+
+    [TestMethod]
+    public void GetConnectionReferences_NoBindingReferencesConnection_ReturnsEmptyList()
+    {
+        var response = testSubject.GetConnectionReferences(new ConnectionViewModel(new Connection(new ConnectionInfo("myOrg", ConnectionServerType.SonarCloud))));
+
+        response.Success.Should().BeTrue();
+        response.ResponseData.Should().BeEmpty();
+    }
+
+    [TestMethod]
+    public void GetConnectionReferences_OneBindingReferencesSonarCloudConnection_ReturnsOneBinding()
+    {
+        var bindingKey = "localBindingKey";
+        var sonarCloud = twoConnections.First(conn => conn.Info.ServerType == ConnectionServerType.SonarCloud);
+        solutionBindingRepository.List().Returns([new BoundServerProject(bindingKey, "myProject", CreateSonarCloudServerConnection(sonarCloud))]);
+
+        var response = testSubject.GetConnectionReferences(new ConnectionViewModel(sonarCloud));
+
+        response.Success.Should().BeTrue();
+        response.ResponseData.Should().Contain(bindingKey);
+    }
+
+    [TestMethod]
+    public void GetConnectionReferences_OneBindingReferencesSonarQubeConnection_ReturnsOneBinding()
+    {
+        var bindingKey = "localBindingKey";
+        var sonarQube = twoConnections.First(conn => conn.Info.ServerType == ConnectionServerType.SonarQube);
+        solutionBindingRepository.List().Returns([new BoundServerProject(bindingKey, "myProject", CreateSonarQubeServerConnection(sonarQube))]);
+
+        var response = testSubject.GetConnectionReferences(new ConnectionViewModel(sonarQube));
+
+        response.Success.Should().BeTrue();
+        response.ResponseData.Should().Contain(bindingKey);
+    }
+
+    [TestMethod]
+    public void GetConnectionReferences_TwoBindingsReferencesSonarQubeConnection_ReturnsTwoBindings()
+    {
+        var sonarQube = twoConnections.First(conn => conn.Info.ServerType == ConnectionServerType.SonarQube);
+        var serverConnectionToBeRemoved = CreateSonarQubeServerConnection(sonarQube);
+        solutionBindingRepository.List().Returns([
+            new BoundServerProject("binding1", "myProject", serverConnectionToBeRemoved),
+            new BoundServerProject("binding2", "myProject2", serverConnectionToBeRemoved)
+        ]);
+
+        var response = testSubject.GetConnectionReferences(new ConnectionViewModel(sonarQube));
+
+        response.Success.Should().BeTrue();
+        response.ResponseData.Should().BeEquivalentTo(["binding1", "binding2"]);
+    }
+
+    [TestMethod]
+    public void GetConnectionReferences_TwoBindingsReferencesSonarCloudConnection_ReturnsTwoBindings()
+    {
+        var sonarCloud = twoConnections.First(conn => conn.Info.ServerType == ConnectionServerType.SonarQube);
+        var serverConnectionToBeRemoved = CreateSonarCloudServerConnection(sonarCloud);
+        solutionBindingRepository.List().Returns([
+            new BoundServerProject("binding1", "myProject", serverConnectionToBeRemoved),
+            new BoundServerProject("binding2", "myProject2", serverConnectionToBeRemoved)
+        ]);
+
+        var response = testSubject.GetConnectionReferences(new ConnectionViewModel(sonarCloud));
+
+        response.Success.Should().BeTrue();
+        response.ResponseData.Should().BeEquivalentTo(["binding1", "binding2"]);
+    }
+
+    [TestMethod]
+    public void GetConnectionReferences_BindingRepositoryThrowsException_ReturnsEmptyList()
+    {
+        var exceptionMsg = "Failed to retrieve bindings";
+        solutionBindingRepository.When(repo => repo.List()).Do(_ => throw new Exception(exceptionMsg));
+
+        var response = testSubject.GetConnectionReferences(new ConnectionViewModel(twoConnections.First()));
+
+        response.Success.Should().BeFalse(); 
+        response.ResponseData.Should().BeEmpty();
+        logger.Received(1).WriteLine(nameof(testSubject.GetConnectionReferences), exceptionMsg);
+    }
+
     private void HasExpectedConnections(IEnumerable<Connection> expectedConnections)
     {
         testSubject.ConnectionViewModels.Should().NotBeNull();
@@ -310,6 +406,9 @@ private void MockServices()
         connectedModeServices.ThreadHandling.Returns(threadHandling);
         connectedModeServices.Logger.Returns(logger);
         MockTryGetConnections(twoConnections);
+
+        solutionBindingRepository = Substitute.For<ISolutionBindingRepository>();
+        connectedModeBindingServices.SolutionBindingRepository.Returns(solutionBindingRepository);
     }
 
     private void MockTryGetConnections(List<Connection> connections)
@@ -325,4 +424,14 @@ private static Connection CreateSonarCloudConnection()
     {
         return new Connection(new ConnectionInfo("mySecondOrg", ConnectionServerType.SonarCloud), false);
     }
+
+    private static ServerConnection.SonarCloud CreateSonarCloudServerConnection(Connection sonarCloud)
+    {
+        return new ServerConnection.SonarCloud(sonarCloud.Info.Id);
+    }
+
+    private static ServerConnection.SonarQube CreateSonarQubeServerConnection(Connection sonarQube)
+    {
+        return new ServerConnection.SonarQube(new Uri(sonarQube.Info.Id));
+    }
 }
diff --git a/src/ConnectedMode/UI/ManageConnections/ManageConnectionsViewModel.cs b/src/ConnectedMode/UI/ManageConnections/ManageConnectionsViewModel.cs
index 8dfb8b5308..3af96d9291 100644
--- a/src/ConnectedMode/UI/ManageConnections/ManageConnectionsViewModel.cs
+++ b/src/ConnectedMode/UI/ManageConnections/ManageConnectionsViewModel.cs
@@ -22,11 +22,13 @@
 using SonarLint.VisualStudio.ConnectedMode.UI.Credentials;
 using SonarLint.VisualStudio.ConnectedMode.UI.Resources;
 using SonarLint.VisualStudio.Core.WPF;
+using VSLangProj;
 
 namespace SonarLint.VisualStudio.ConnectedMode.UI.ManageConnections
 {
-    public class ManageConnectionsViewModel(IConnectedModeServices connectedModeServices, IProgressReporterViewModel progressReporterViewModel) : ViewModelBase
+    public class ManageConnectionsViewModel(IConnectedModeServices connectedModeServices, IConnectedModeBindingServices connectedModeBindingServices, IProgressReporterViewModel progressReporterViewModel) : ViewModelBase
     {
+        public IConnectedModeBindingServices ConnectedModeBindingServices { get; } = connectedModeBindingServices;
         public IProgressReporterViewModel ProgressReporterViewModel { get; } = progressReporterViewModel;
         public ObservableCollection<ConnectionViewModel> ConnectionViewModels { get; } = [];
         public bool NoConnectionExists => ConnectionViewModels.Count == 0;
@@ -40,7 +42,7 @@ internal async Task LoadConnectionsWithProgressAsync()
             await ProgressReporterViewModel.ExecuteTaskWithProgressAsync(validationParams);
         }
 
-        public async Task RemoveConnectionWithProgressAsync(ConnectionViewModel connectionViewModel)
+        internal async Task RemoveConnectionWithProgressAsync(ConnectionViewModel connectionViewModel)
         {
             var validationParams = new TaskToPerformParams<AdapterResponse>(
                 async () => await SafeExecuteActionAsync(() => RemoveConnectionViewModel(connectionViewModel)),
@@ -49,6 +51,42 @@ public async Task RemoveConnectionWithProgressAsync(ConnectionViewModel connecti
             await ProgressReporterViewModel.ExecuteTaskWithProgressAsync(validationParams);
         }
 
+        internal async Task<List<string>> GetConnectionReferencesWithProgressAsync(ConnectionViewModel connectionViewModel)
+        {
+            List<string> references = [];
+            var validationParams = new TaskToPerformParams<AdapterResponseWithData<List<string>>>(
+                async () =>
+                {
+                    return await connectedModeServices.ThreadHandling.RunOnBackgroundThread(() =>
+                    {
+                        var adapterResponse = GetConnectionReferences(connectionViewModel);
+                        references = adapterResponse.ResponseData;
+                        return Task.FromResult(adapterResponse);
+                    });
+                },
+                UiResources.CalculatingConnectionReferencesText,
+                UiResources.CalculatingConnectionReferencesFailedText);
+            await ProgressReporterViewModel.ExecuteTaskWithProgressAsync(validationParams);
+            return references;
+        }
+
+        internal AdapterResponseWithData<List<string>> GetConnectionReferences(ConnectionViewModel connectionViewModel)
+        {
+            try
+            {
+                var bindings = ConnectedModeBindingServices.SolutionBindingRepository.List();
+                var references = bindings
+                    .Where(x => ConnectionInfo.From(x.ServerConnection).Id == connectionViewModel.Connection.Info.Id)
+                    .Select(x => x.LocalBindingKey).ToList();
+                return new AdapterResponseWithData<List<string>>(true, references);
+            }
+            catch (Exception ex)
+            {
+                connectedModeServices.Logger.WriteLine(nameof(GetConnectionReferences), ex.Message);
+                return new AdapterResponseWithData<List<string>>(false, []);
+            }
+        }
+
         internal async Task CreateConnectionsWithProgressAsync(Connection connection, ICredentialsModel credentialsModel)
         {
             var validationParams = new TaskToPerformParams<AdapterResponse>(
diff --git a/src/ConnectedMode/UI/Resources/UiResources.Designer.cs b/src/ConnectedMode/UI/Resources/UiResources.Designer.cs
index 1f51347c68..d88ded6b9f 100644
--- a/src/ConnectedMode/UI/Resources/UiResources.Designer.cs
+++ b/src/ConnectedMode/UI/Resources/UiResources.Designer.cs
@@ -150,6 +150,24 @@ public static string BoundToLabel {
             }
         }
         
+        /// <summary>
+        ///   Looks up a localized string similar to Calculating the connection references failed.
+        /// </summary>
+        public static string CalculatingConnectionReferencesFailedText {
+            get {
+                return ResourceManager.GetString("CalculatingConnectionReferencesFailedText", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to Calculating connection references....
+        /// </summary>
+        public static string CalculatingConnectionReferencesText {
+            get {
+                return ResourceManager.GetString("CalculatingConnectionReferencesText", resourceCulture);
+            }
+        }
+        
         /// <summary>
         ///   Looks up a localized string similar to Cancel.
         /// </summary>
diff --git a/src/ConnectedMode/UI/Resources/UiResources.resx b/src/ConnectedMode/UI/Resources/UiResources.resx
index c661a8a517..dc77649fec 100644
--- a/src/ConnectedMode/UI/Resources/UiResources.resx
+++ b/src/ConnectedMode/UI/Resources/UiResources.resx
@@ -391,4 +391,10 @@ Please manually add the connection through "Manage Connections" and then try aga
   <data name="NotFoundConnectionForSharedBindingMessageBoxCaption" xml:space="preserve">
     <value>Connection not found</value>
   </data>
+  <data name="CalculatingConnectionReferencesFailedText" xml:space="preserve">
+    <value>Calculating the connection references failed</value>
+  </data>
+  <data name="CalculatingConnectionReferencesText" xml:space="preserve">
+    <value>Calculating connection references...</value>
+  </data>
 </root>
\ No newline at end of file

From fc09f81c75318c67b79afe7d0345caf6bc334ccb Mon Sep 17 00:00:00 2001
From: Gabriela Trutan <gabriela.trutan@sonarsource.com>
Date: Tue, 24 Sep 2024 13:17:22 +0200
Subject: [PATCH 04/10] SLVS-1448 Add dialog to prevent deleting a connection
 that is referenced

---
 .../PreventDeleteConnectionViewModelTests.cs  | 65 +++++++++++++++++
 src/ConnectedMode/ConnectedMode.csproj        |  3 +
 .../PreventDeleteConnectionDialog.xaml        | 73 +++++++++++++++++++
 .../PreventDeleteConnectionDialog.xaml.cs     | 51 +++++++++++++
 .../PreventDeleteConnectionViewModel.cs       | 37 ++++++++++
 .../UI/Resources/UiResources.Designer.cs      | 27 +++++++
 .../UI/Resources/UiResources.resx             | 15 ++++
 7 files changed, 271 insertions(+)
 create mode 100644 src/ConnectedMode.UnitTests/UI/DeleteConnection/PreventDeleteConnectionViewModelTests.cs
 create mode 100644 src/ConnectedMode/UI/DeleteConnection/PreventDeleteConnectionDialog.xaml
 create mode 100644 src/ConnectedMode/UI/DeleteConnection/PreventDeleteConnectionDialog.xaml.cs
 create mode 100644 src/ConnectedMode/UI/DeleteConnection/PreventDeleteConnectionViewModel.cs

diff --git a/src/ConnectedMode.UnitTests/UI/DeleteConnection/PreventDeleteConnectionViewModelTests.cs b/src/ConnectedMode.UnitTests/UI/DeleteConnection/PreventDeleteConnectionViewModelTests.cs
new file mode 100644
index 0000000000..76e22efa62
--- /dev/null
+++ b/src/ConnectedMode.UnitTests/UI/DeleteConnection/PreventDeleteConnectionViewModelTests.cs
@@ -0,0 +1,65 @@
+/*
+ * SonarLint for Visual Studio
+ * Copyright (C) 2016-2024 SonarSource SA
+ * mailto:info AT sonarsource DOT com
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 3 of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+ */
+
+using SonarLint.VisualStudio.ConnectedMode.UI.DeleteConnection;
+
+namespace SonarLint.VisualStudio.ConnectedMode.UnitTests.UI.DeleteConnection;
+
+[TestClass]
+public class PreventDeleteConnectionViewModelTests
+{
+    [TestMethod]
+    public void Ctor_SetsProperties()
+    {
+        var projectsToUnbind = Substitute.For<IReadOnlyList<string>>();
+        var connectionInfo = new ConnectionInfo(default, default);
+
+        var testSubject = new PreventDeleteConnectionViewModel(projectsToUnbind, connectionInfo);
+
+        testSubject.ConnectionInfo.Should().BeSameAs(connectionInfo);
+        testSubject.ProjectsToUnbind.Should().BeSameAs(projectsToUnbind);
+    }
+
+    [DataTestMethod]
+    public void DisplayProjectList_MultipleProjectsToUnbind_ReturnsTrue()
+    {
+        var projects = new[] { "binding1", "binding2"};
+
+        var testSubject = new PreventDeleteConnectionViewModel(projects, new ConnectionInfo(default, default));
+
+        testSubject.DisplayProjectList.Should().BeTrue();
+    }
+
+    [DataTestMethod]
+    public void DisplayProjectList_ProjectsIsNull_ReturnsFalse()
+    {
+        var testSubject = new PreventDeleteConnectionViewModel(null, new ConnectionInfo(default, default));
+
+        testSubject.DisplayProjectList.Should().BeFalse();
+    }
+
+    [DataTestMethod]
+    public void DisplayProjectList_NoProjectsToUnbind_ReturnsFalse()
+    {
+        var testSubject = new PreventDeleteConnectionViewModel([], new ConnectionInfo(default, default));
+
+        testSubject.DisplayProjectList.Should().BeFalse();
+    }
+}
diff --git a/src/ConnectedMode/ConnectedMode.csproj b/src/ConnectedMode/ConnectedMode.csproj
index 0664c21d34..b7e4cb3a15 100644
--- a/src/ConnectedMode/ConnectedMode.csproj
+++ b/src/ConnectedMode/ConnectedMode.csproj
@@ -53,6 +53,9 @@
 
   <ItemGroup>
     <Page Include="Migration\Wizard\MigrationWizardWindow.xaml" />
+    <Page Include="UI\DeleteConnection\PreventDeleteConnectionDialog.xaml">
+      <Generator>MSBuild:Compile</Generator>
+    </Page>
     <Page Include="UI\ProgressAndErrorReporterComponent.xaml">
       <Generator>MSBuild:Compile</Generator>
     </Page>
diff --git a/src/ConnectedMode/UI/DeleteConnection/PreventDeleteConnectionDialog.xaml b/src/ConnectedMode/UI/DeleteConnection/PreventDeleteConnectionDialog.xaml
new file mode 100644
index 0000000000..8287d870f6
--- /dev/null
+++ b/src/ConnectedMode/UI/DeleteConnection/PreventDeleteConnectionDialog.xaml
@@ -0,0 +1,73 @@
+<Window x:Class="SonarLint.VisualStudio.ConnectedMode.UI.DeleteConnection.PreventDeleteConnectionDialog"
+        xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
+        xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
+        xmlns:res="clr-namespace:SonarLint.VisualStudio.ConnectedMode.UI.Resources"
+        xmlns:ui="clr-namespace:SonarLint.VisualStudio.ConnectedMode.UI"
+        xmlns:converters="clr-namespace:SonarLint.VisualStudio.Core.WPF;assembly=SonarLint.VisualStudio.Core"
+        Title="{x:Static res:UiResources.DeleteConnectionDialogTitle}"
+        Width="600"
+        MinHeight="200"
+        MaxHeight="400"
+        ResizeMode="NoResize"
+        SizeToContent="Height"
+        WindowStartupLocation="CenterOwner"
+        FocusManager.FocusedElement="{Binding ElementName=OrganizationComboBox}"
+        x:Name="This">
+    <Window.Resources>
+        <ResourceDictionary>
+            <ResourceDictionary.MergedDictionaries>
+                <ResourceDictionary
+                    Source="pack://application:,,,/SonarLint.VisualStudio.ConnectedMode;component/UI/Resources/Styles.xaml" />
+            </ResourceDictionary.MergedDictionaries>
+            <converters:BoolToVisibilityConverter x:Key="TrueToVisibleConverter" FalseValue="Collapsed"
+                                                  TrueValue="Visible" />
+            <converters:BoolToVisibilityConverter x:Key="FalseToVisibleConverter" FalseValue="Visible"
+                                                  TrueValue="Collapsed" />
+        </ResourceDictionary>
+    </Window.Resources>
+    <Window.Style>
+        <Style TargetType="Window" BasedOn="{StaticResource {x:Type Window}}"></Style>
+    </Window.Style>
+
+    <Grid DataContext="{Binding ElementName=This, Path=ViewModel}" Margin="15">
+        <Grid.RowDefinitions>
+            <RowDefinition Height="Auto" />
+            <RowDefinition Height="*" />
+            <RowDefinition Height="Auto" />
+        </Grid.RowDefinitions>
+        <TextBlock Grid.Row="0" Margin="0, 0, 0, 20">
+            <Run Text="{x:Static res:UiResources.DeleteConnectionNotPossibleDescription}" />
+            <InlineUIContainer Style="{StaticResource ConnectionInfoInlineWrapper}">
+                <ui:ConnectionInfoComponent ConnectionInfo="{Binding ConnectionInfo}" />
+            </InlineUIContainer>
+        </TextBlock>
+        <TextBlock Grid.Row="1"
+                   Text="{x:Static res:UiResources.DeleteConnectionNoProjectsLabel}"
+                   Visibility="{Binding DisplayProjectList, Converter={StaticResource FalseToVisibleConverter}}" />
+        <Grid Grid.Row="1" Visibility="{Binding DisplayProjectList, Converter={StaticResource TrueToVisibleConverter}}">
+            <Grid.RowDefinitions>
+                <RowDefinition Height="Auto" />
+                <RowDefinition Height="*" />
+                <RowDefinition Height="Auto" />
+            </Grid.RowDefinitions>
+            <TextBlock Grid.Row="0" Text="{x:Static res:UiResources.DeleteConnectionBindingListToUnbindLabel}" />
+            <ListBox Grid.Row="1"
+                     Margin="0, 10"
+                     ItemContainerStyle="{StaticResource NoSelectionListBoxItemStyle}"
+                     ItemsSource="{Binding ProjectsToUnbind}">
+            </ListBox>
+            <TextBlock Grid.Row="2" Text="{x:Static res:UiResources.DeleteBindingHelpText}" Margin="0,20">
+                <Hyperlink NavigateUri="https://docs.sonarsource.com/sonarlint/visual-studio/team-features/connected-mode-setup/#unbinding-a-project" RequestNavigate="ViewWebsite">here</Hyperlink>
+            </TextBlock>
+        </Grid>
+        <Grid Grid.Row="2" Margin="0, 20, 0, 0">
+            <Grid.ColumnDefinitions>
+                <ColumnDefinition Width="*" />
+                <ColumnDefinition Width="*" />
+            </Grid.ColumnDefinitions>
+            <StackPanel Grid.Column="1" Style="{StaticResource DialogButtonsPanel}">
+                <Button Content="{x:Static res:UiResources.OkButton}" IsDefault="True" IsCancel="True"/>
+            </StackPanel>
+        </Grid>
+    </Grid>
+</Window>
\ No newline at end of file
diff --git a/src/ConnectedMode/UI/DeleteConnection/PreventDeleteConnectionDialog.xaml.cs b/src/ConnectedMode/UI/DeleteConnection/PreventDeleteConnectionDialog.xaml.cs
new file mode 100644
index 0000000000..85bc388b43
--- /dev/null
+++ b/src/ConnectedMode/UI/DeleteConnection/PreventDeleteConnectionDialog.xaml.cs
@@ -0,0 +1,51 @@
+/*
+ * SonarLint for Visual Studio
+ * Copyright (C) 2016-2024 SonarSource SA
+ * mailto:info AT sonarsource DOT com
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 3 of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+ */
+
+using System.Diagnostics.CodeAnalysis;
+using System.Windows;
+using System.Windows.Navigation;
+using SonarLint.VisualStudio.Core;
+
+namespace SonarLint.VisualStudio.ConnectedMode.UI.DeleteConnection;
+
+[ExcludeFromCodeCoverage]
+public partial class PreventDeleteConnectionDialog : Window
+{
+    private readonly IBrowserService browserService;
+    public PreventDeleteConnectionViewModel ViewModel { get; }
+    
+    public PreventDeleteConnectionDialog(IReadOnlyList<string> projectsToUnbind, ConnectionInfo connectionInfo, IBrowserService browserService)
+    {
+        this.browserService = browserService;
+        ViewModel = new PreventDeleteConnectionViewModel(projectsToUnbind, connectionInfo);
+        InitializeComponent();
+    }
+
+    private void DeleteButton_OnClick(object sender, RoutedEventArgs e)
+    {
+        DialogResult = true;
+    }
+
+    private void ViewWebsite(object sender, RequestNavigateEventArgs e)
+    {
+        browserService.Navigate(e.Uri.AbsoluteUri);
+    }
+}
+
diff --git a/src/ConnectedMode/UI/DeleteConnection/PreventDeleteConnectionViewModel.cs b/src/ConnectedMode/UI/DeleteConnection/PreventDeleteConnectionViewModel.cs
new file mode 100644
index 0000000000..a0155dab7e
--- /dev/null
+++ b/src/ConnectedMode/UI/DeleteConnection/PreventDeleteConnectionViewModel.cs
@@ -0,0 +1,37 @@
+/*
+ * SonarLint for Visual Studio
+ * Copyright (C) 2016-2024 SonarSource SA
+ * mailto:info AT sonarsource DOT com
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 3 of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+ */
+
+using SonarLint.VisualStudio.Core.WPF;
+
+namespace SonarLint.VisualStudio.ConnectedMode.UI.DeleteConnection;
+
+public class PreventDeleteConnectionViewModel : ViewModelBase
+{
+    public PreventDeleteConnectionViewModel(IReadOnlyList<string> projectsToUnbind, ConnectionInfo connectionInfo)
+    {
+        ProjectsToUnbind = projectsToUnbind;
+        ConnectionInfo = connectionInfo;
+    }
+
+    public IReadOnlyList<string> ProjectsToUnbind { get; }
+    public ConnectionInfo ConnectionInfo { get; }
+
+    public bool DisplayProjectList => ProjectsToUnbind is not null && ProjectsToUnbind.Count > 0;
+}
diff --git a/src/ConnectedMode/UI/Resources/UiResources.Designer.cs b/src/ConnectedMode/UI/Resources/UiResources.Designer.cs
index d88ded6b9f..0bfbc4742c 100644
--- a/src/ConnectedMode/UI/Resources/UiResources.Designer.cs
+++ b/src/ConnectedMode/UI/Resources/UiResources.Designer.cs
@@ -258,6 +258,15 @@ public static string CredentialsLabel {
             }
         }
         
+        /// <summary>
+        ///   Looks up a localized string similar to To manually delete a binding, please follow the &quot;Unbinding a project&quot; documentation .
+        /// </summary>
+        public static string DeleteBindingHelpText {
+            get {
+                return ResourceManager.GetString("DeleteBindingHelpText", resourceCulture);
+            }
+        }
+        
         /// <summary>
         ///   Looks up a localized string similar to Delete.
         /// </summary>
@@ -276,6 +285,15 @@ public static string DeleteConnectionBindingListLabel {
             }
         }
         
+        /// <summary>
+        ///   Looks up a localized string similar to The following project bindings must first be manually removed:.
+        /// </summary>
+        public static string DeleteConnectionBindingListToUnbindLabel {
+            get {
+                return ResourceManager.GetString("DeleteConnectionBindingListToUnbindLabel", resourceCulture);
+            }
+        }
+        
         /// <summary>
         ///   Looks up a localized string similar to These projects bindings will no longer be in connected mode!.
         /// </summary>
@@ -312,6 +330,15 @@ public static string DeleteConnectionNoProjectsLabel {
             }
         }
         
+        /// <summary>
+        ///   Looks up a localized string similar to The following connection can not be deleted:.
+        /// </summary>
+        public static string DeleteConnectionNotPossibleDescription {
+            get {
+                return ResourceManager.GetString("DeleteConnectionNotPossibleDescription", resourceCulture);
+            }
+        }
+        
         /// <summary>
         ///   Looks up a localized string similar to Authentication via username and password is deprecated and will be removed in the future. Please use a token instead..
         /// </summary>
diff --git a/src/ConnectedMode/UI/Resources/UiResources.resx b/src/ConnectedMode/UI/Resources/UiResources.resx
index dc77649fec..b1936e2c04 100644
--- a/src/ConnectedMode/UI/Resources/UiResources.resx
+++ b/src/ConnectedMode/UI/Resources/UiResources.resx
@@ -391,6 +391,21 @@ Please manually add the connection through "Manage Connections" and then try aga
   <data name="NotFoundConnectionForSharedBindingMessageBoxCaption" xml:space="preserve">
     <value>Connection not found</value>
   </data>
+  <data name="DeleteBindingHelpText" xml:space="preserve">
+    <value>To manually delete a binding, please follow the "Unbinding a project" documentation </value>
+  </data>
+  <data name="DeleteConnectionBindingListToUnbindLabel" xml:space="preserve">
+    <value>The following project bindings must first be manually removed:</value>
+  </data>
+  <data name="DeleteConnectionNotPossibleDescription" xml:space="preserve">
+    <value>The following connection can not be deleted:</value>
+  </data>
+  <data name="CalculatingConnectionReferencesFailedText" xml:space="preserve">
+    <value>Calculating the connection references failed</value>
+  </data>
+  <data name="CalculatingConnectionReferencesText" xml:space="preserve">
+    <value>Calculating connection references...</value>
+  </data>
   <data name="CalculatingConnectionReferencesFailedText" xml:space="preserve">
     <value>Calculating the connection references failed</value>
   </data>

From 180f30acb354571415d0a46f9c3521549f133879 Mon Sep 17 00:00:00 2001
From: Gabriela Trutan <gabriela.trutan@sonarsource.com>
Date: Tue, 24 Sep 2024 13:24:17 +0200
Subject: [PATCH 05/10] SLVS-1448 Prevent deleting connection when in use

---
 .../ManageBinding/ManageBindingDialog.xaml.cs |  4 +++-
 .../ManageConnectionsDialog.xaml.cs           | 22 +++++++++++++------
 2 files changed, 18 insertions(+), 8 deletions(-)

diff --git a/src/ConnectedMode/UI/ManageBinding/ManageBindingDialog.xaml.cs b/src/ConnectedMode/UI/ManageBinding/ManageBindingDialog.xaml.cs
index 03125147b0..57c4230374 100644
--- a/src/ConnectedMode/UI/ManageBinding/ManageBindingDialog.xaml.cs
+++ b/src/ConnectedMode/UI/ManageBinding/ManageBindingDialog.xaml.cs
@@ -31,6 +31,7 @@ namespace SonarLint.VisualStudio.ConnectedMode.UI.ManageBinding;
 public partial class ManageBindingDialog : Window
 {
     private readonly IConnectedModeServices connectedModeServices;
+    private readonly IConnectedModeBindingServices connectedModeBindingServices;
     private readonly bool useSharedBindingOnInitialization;
 
     public ManageBindingDialog(
@@ -39,6 +40,7 @@ public ManageBindingDialog(
         bool useSharedBindingOnInitialization = false)
     {
         this.connectedModeServices = connectedModeServices;
+        this.connectedModeBindingServices = connectedModeBindingServices;
         this.useSharedBindingOnInitialization = useSharedBindingOnInitialization;
         ViewModel = new ManageBindingViewModel(connectedModeServices, connectedModeBindingServices, new ProgressReporterViewModel());
         InitializeComponent();
@@ -48,7 +50,7 @@ public ManageBindingDialog(
 
     private async void ManageConnections_OnClick(object sender, RoutedEventArgs e)
     {
-        new ManageConnectionsDialog(connectedModeServices).ShowDialog(this);
+        new ManageConnectionsDialog(connectedModeServices, connectedModeBindingServices).ShowDialog(this);
         await ViewModel.InitializeDataAsync();
     }
 
diff --git a/src/ConnectedMode/UI/ManageConnections/ManageConnectionsDialog.xaml.cs b/src/ConnectedMode/UI/ManageConnections/ManageConnectionsDialog.xaml.cs
index 0d62870260..bab1e59c3d 100644
--- a/src/ConnectedMode/UI/ManageConnections/ManageConnectionsDialog.xaml.cs
+++ b/src/ConnectedMode/UI/ManageConnections/ManageConnectionsDialog.xaml.cs
@@ -22,9 +22,7 @@
 using System.Windows;
 using SonarLint.VisualStudio.ConnectedMode.UI.Credentials;
 using SonarLint.VisualStudio.ConnectedMode.UI.DeleteConnection;
-using SonarLint.VisualStudio.ConnectedMode.UI.ManageBinding;
 using SonarLint.VisualStudio.ConnectedMode.UI.OrganizationSelection;
-using SonarLint.VisualStudio.ConnectedMode.UI.ProjectSelection;
 using SonarLint.VisualStudio.ConnectedMode.UI.ServerSelection;
 
 namespace SonarLint.VisualStudio.ConnectedMode.UI.ManageConnections
@@ -36,10 +34,10 @@ public partial class ManageConnectionsDialog : Window
 
         public ManageConnectionsViewModel ViewModel { get; }
 
-        public ManageConnectionsDialog(IConnectedModeServices connectedModeServices)
+        public ManageConnectionsDialog(IConnectedModeServices connectedModeServices, IConnectedModeBindingServices connectedModeBindingServices)
         {
             this.connectedModeServices = connectedModeServices;
-            ViewModel = new ManageConnectionsViewModel(connectedModeServices, new ProgressReporterViewModel());
+            ViewModel = new ManageConnectionsViewModel(connectedModeServices, connectedModeBindingServices, new ProgressReporterViewModel());
             InitializeComponent();
         }
 
@@ -108,11 +106,21 @@ private async void RemoveConnectionButton_OnClick(object sender, RoutedEventArgs
                 return;
             }
 
-            var deleteConnectionDialog = new DeleteConnectionDialog([], connectionViewModel.Connection.Info);
-            if(deleteConnectionDialog.ShowDialog(this) == true)
+            var connectionReferences = await ViewModel.GetConnectionReferencesWithProgressAsync(connectionViewModel);
+            if (connectionReferences.Count > 0)
             {
-                await ViewModel.RemoveConnectionWithProgressAsync(connectionViewModel);
+                var preventConnectionDeleteDialog = new PreventDeleteConnectionDialog(connectionReferences, connectionViewModel.Connection.Info, connectedModeServices.BrowserService);
+                preventConnectionDeleteDialog.ShowDialog(this);
             }
+            else
+            {
+                var deleteConnectionDialog = new DeleteConnectionDialog([], connectionViewModel.Connection.Info);
+                if (deleteConnectionDialog.ShowDialog(this) == true)
+                {
+                    await ViewModel.RemoveConnectionWithProgressAsync(connectionViewModel);
+                }
+            }
+           
         }
     }
 }

From 6f39207feb943e9cd208b87eb5390428b9397b70 Mon Sep 17 00:00:00 2001
From: Gabriela Trutan <gabriela.trutan@sonarsource.com>
Date: Wed, 25 Sep 2024 09:13:52 +0200
Subject: [PATCH 06/10] SLVS-1448 Fix quaility gate

---
 .../ManageConnectionsViewModelTest.cs         | 30 ++++++++++++++++++-
 .../ManageConnectionsViewModel.cs             | 25 ++++++++--------
 2 files changed, 42 insertions(+), 13 deletions(-)

diff --git a/src/ConnectedMode.UnitTests/UI/ManageConnections/ManageConnectionsViewModelTest.cs b/src/ConnectedMode.UnitTests/UI/ManageConnections/ManageConnectionsViewModelTest.cs
index 9dadf07cf0..95564a2613 100644
--- a/src/ConnectedMode.UnitTests/UI/ManageConnections/ManageConnectionsViewModelTest.cs
+++ b/src/ConnectedMode.UnitTests/UI/ManageConnections/ManageConnectionsViewModelTest.cs
@@ -18,6 +18,7 @@
  * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
  */
 
+using System;
 using System.ComponentModel;
 using SonarLint.VisualStudio.ConnectedMode.UI;
 using SonarLint.VisualStudio.ConnectedMode.UI.Credentials;
@@ -25,6 +26,7 @@
 using SonarLint.VisualStudio.ConnectedMode.UI.Resources;
 using SonarLint.VisualStudio.Core;
 using SonarLint.VisualStudio.Core.Binding;
+using SonarLint.VisualStudio.TestInfrastructure;
 
 namespace SonarLint.VisualStudio.ConnectedMode.UnitTests.UI.ManageConnections;
 
@@ -282,8 +284,10 @@ public void CreateNewConnection_ConnectionWasNotAddedToRepository_DoesNotAddConn
     }
 
     [TestMethod]
-    public async Task GetConnectionReferencesWithProgressAsync_InitializesDataAndReportsProgress()
+    public async Task GetConnectionReferencesWithProgressAsync_CalculatesReferencesAndReportsProgress()
     {
+        progressReporterViewModel.ExecuteTaskWithProgressAsync(Arg.Any<TaskToPerformParams<AdapterResponseWithData<List<string>>>>()).Returns(new AdapterResponseWithData<List<string>>(true, []));
+
         await testSubject.GetConnectionReferencesWithProgressAsync(new ConnectionViewModel(new Connection(new ConnectionInfo("myOrg", ConnectionServerType.SonarCloud))));
 
         await progressReporterViewModel.Received(1)
@@ -293,6 +297,30 @@ await progressReporterViewModel.Received(1)
                     x.WarningText == UiResources.CalculatingConnectionReferencesFailedText));
     }
 
+    [TestMethod]
+    public async Task GetConnectionReferencesOnBackgroundThreadAsync_RunsOnBackgroundThread()
+    {
+        threadHandling.RunOnBackgroundThread(Arg.Any<Func<Task<AdapterResponseWithData<List<string>>>>>()).Returns(new AdapterResponseWithData<List<string>>(true, []));
+
+        await testSubject.GetConnectionReferencesOnBackgroundThreadAsync(new ConnectionViewModel(new Connection(new ConnectionInfo("myOrg", ConnectionServerType.SonarCloud))));
+
+        await threadHandling.Received(1).RunOnBackgroundThread(Arg.Any<Func<Task<AdapterResponseWithData<List<string>>>>>());
+    }
+
+    [TestMethod]
+    [DataRow(true)]
+    [DataRow(false)]
+    public async Task GetConnectionReferencesOnBackgroundThreadAsync_ReturnsCalculatedReferences(bool expectedResponse)
+    {
+        var bindingKey = "localBindingKey";
+        threadHandling.RunOnBackgroundThread(Arg.Any<Func<Task<AdapterResponseWithData<List<string>>>>>()).Returns(new AdapterResponseWithData<List<string>>(expectedResponse, [bindingKey]));
+
+        var responses = await testSubject.GetConnectionReferencesOnBackgroundThreadAsync(new ConnectionViewModel(new Connection(new ConnectionInfo("myOrg", ConnectionServerType.SonarCloud))));
+
+        responses.Success.Should().Be(expectedResponse);
+        responses.ResponseData.Should().Contain(bindingKey);
+    }
+
     [TestMethod]
     public void GetConnectionReferences_NoBindingReferencesConnection_ReturnsEmptyList()
     {
diff --git a/src/ConnectedMode/UI/ManageConnections/ManageConnectionsViewModel.cs b/src/ConnectedMode/UI/ManageConnections/ManageConnectionsViewModel.cs
index 3af96d9291..d4dcf5a481 100644
--- a/src/ConnectedMode/UI/ManageConnections/ManageConnectionsViewModel.cs
+++ b/src/ConnectedMode/UI/ManageConnections/ManageConnectionsViewModel.cs
@@ -53,21 +53,22 @@ internal async Task RemoveConnectionWithProgressAsync(ConnectionViewModel connec
 
         internal async Task<List<string>> GetConnectionReferencesWithProgressAsync(ConnectionViewModel connectionViewModel)
         {
-            List<string> references = [];
             var validationParams = new TaskToPerformParams<AdapterResponseWithData<List<string>>>(
-                async () =>
-                {
-                    return await connectedModeServices.ThreadHandling.RunOnBackgroundThread(() =>
-                    {
-                        var adapterResponse = GetConnectionReferences(connectionViewModel);
-                        references = adapterResponse.ResponseData;
-                        return Task.FromResult(adapterResponse);
-                    });
-                },
+                async () => await GetConnectionReferencesOnBackgroundThreadAsync(connectionViewModel),
                 UiResources.CalculatingConnectionReferencesText,
                 UiResources.CalculatingConnectionReferencesFailedText);
-            await ProgressReporterViewModel.ExecuteTaskWithProgressAsync(validationParams);
-            return references;
+            var response = await ProgressReporterViewModel.ExecuteTaskWithProgressAsync(validationParams);
+
+            return response.ResponseData;
+        }
+
+        internal async Task<AdapterResponseWithData<List<string>>> GetConnectionReferencesOnBackgroundThreadAsync(ConnectionViewModel connectionViewModel)
+        {
+            return await connectedModeServices.ThreadHandling.RunOnBackgroundThread(() =>
+            {
+                var adapterResponse = GetConnectionReferences(connectionViewModel);
+                return Task.FromResult(adapterResponse);
+            });
         }
 
         internal AdapterResponseWithData<List<string>> GetConnectionReferences(ConnectionViewModel connectionViewModel)

From b79b6592b4c401d9b8c2ed7caa54f5376aa37af1 Mon Sep 17 00:00:00 2001
From: Gabriela Trutan <gabriela.trutan@sonarsource.com>
Date: Wed, 25 Sep 2024 13:51:22 +0200
Subject: [PATCH 07/10] SLVS-1448 Remove unused usings.

---
 .../UI/ManageConnections/ManageConnectionsViewModelTest.cs      | 2 --
 .../UI/ManageConnections/ManageConnectionsViewModel.cs          | 1 -
 2 files changed, 3 deletions(-)

diff --git a/src/ConnectedMode.UnitTests/UI/ManageConnections/ManageConnectionsViewModelTest.cs b/src/ConnectedMode.UnitTests/UI/ManageConnections/ManageConnectionsViewModelTest.cs
index 95564a2613..a85d7da31e 100644
--- a/src/ConnectedMode.UnitTests/UI/ManageConnections/ManageConnectionsViewModelTest.cs
+++ b/src/ConnectedMode.UnitTests/UI/ManageConnections/ManageConnectionsViewModelTest.cs
@@ -18,7 +18,6 @@
  * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
  */
 
-using System;
 using System.ComponentModel;
 using SonarLint.VisualStudio.ConnectedMode.UI;
 using SonarLint.VisualStudio.ConnectedMode.UI.Credentials;
@@ -26,7 +25,6 @@
 using SonarLint.VisualStudio.ConnectedMode.UI.Resources;
 using SonarLint.VisualStudio.Core;
 using SonarLint.VisualStudio.Core.Binding;
-using SonarLint.VisualStudio.TestInfrastructure;
 
 namespace SonarLint.VisualStudio.ConnectedMode.UnitTests.UI.ManageConnections;
 
diff --git a/src/ConnectedMode/UI/ManageConnections/ManageConnectionsViewModel.cs b/src/ConnectedMode/UI/ManageConnections/ManageConnectionsViewModel.cs
index d4dcf5a481..7d9fbf060b 100644
--- a/src/ConnectedMode/UI/ManageConnections/ManageConnectionsViewModel.cs
+++ b/src/ConnectedMode/UI/ManageConnections/ManageConnectionsViewModel.cs
@@ -22,7 +22,6 @@
 using SonarLint.VisualStudio.ConnectedMode.UI.Credentials;
 using SonarLint.VisualStudio.ConnectedMode.UI.Resources;
 using SonarLint.VisualStudio.Core.WPF;
-using VSLangProj;
 
 namespace SonarLint.VisualStudio.ConnectedMode.UI.ManageConnections
 {

From f9999822026e92b48f628fc1c4bb11c7bc69ac59 Mon Sep 17 00:00:00 2001
From: Gabriela Trutan <gabriela.trutan@sonarsource.com>
Date: Wed, 25 Sep 2024 14:21:13 +0200
Subject: [PATCH 08/10] SLVS-1448 Fix failing tests caused by static fields
 that are modified in some tests.

---
 .../SlCoreConnectionAdapterTests.cs           | 34 +++++++++----------
 1 file changed, 17 insertions(+), 17 deletions(-)

diff --git a/src/ConnectedMode.UnitTests/SlCoreConnectionAdapterTests.cs b/src/ConnectedMode.UnitTests/SlCoreConnectionAdapterTests.cs
index b3f6423852..f6eef10f5e 100644
--- a/src/ConnectedMode.UnitTests/SlCoreConnectionAdapterTests.cs
+++ b/src/ConnectedMode.UnitTests/SlCoreConnectionAdapterTests.cs
@@ -39,8 +39,8 @@ namespace SonarLint.VisualStudio.ConnectedMode.UnitTests;
 public class SlCoreConnectionAdapterTests
 {
     private static readonly BasicAuthCredentials ValidToken = new ("I_AM_JUST_A_TOKEN", new SecureString());
-    private static readonly ServerConnection.SonarQube SonarQubeConnection = new(new Uri("http://localhost:9000/"), new ServerConnectionSettings(true), ValidToken);
-    private static readonly ServerConnection.SonarCloud SonarCloudConnection = new("myOrg", new ServerConnectionSettings(true), ValidToken);
+    private readonly ServerConnection.SonarQube sonarQubeConnection = new(new Uri("http://localhost:9000/"), new ServerConnectionSettings(true), ValidToken);
+    private readonly ServerConnection.SonarCloud sonarCloudConnection = new("myOrg", new ServerConnectionSettings(true), ValidToken);
     
     private SlCoreConnectionAdapter testSubject;
     private ISLCoreServiceProvider slCoreServiceProvider;
@@ -258,7 +258,7 @@ public async Task GetAllProjectsAsync_SwitchesToBackgroundThread()
         var threadHandlingMock = Substitute.For<IThreadHandling>();
         var slCoreConnectionAdapter = new SlCoreConnectionAdapter(slCoreServiceProvider, threadHandlingMock, logger);
             
-        await slCoreConnectionAdapter.GetAllProjectsAsync(SonarQubeConnection);
+        await slCoreConnectionAdapter.GetAllProjectsAsync(sonarQubeConnection);
 
         await threadHandlingMock.Received(1).RunOnBackgroundThread(Arg.Any<Func<Task<AdapterResponseWithData<List<ServerProject>>>>>());
     }
@@ -268,7 +268,7 @@ public async Task GetAllProjectsAsync_GettingConnectionConfigurationSLCoreServic
     {
         slCoreServiceProvider.TryGetTransientService(out IConnectionConfigurationSLCoreService _).Returns(false);
 
-        var response = await testSubject.GetAllProjectsAsync(SonarQubeConnection);
+        var response = await testSubject.GetAllProjectsAsync(sonarQubeConnection);
 
         logger.Received(1).LogVerbose($"[{nameof(IConnectionConfigurationSLCoreService)}] {SLCoreStrings.ServiceProviderNotInitialized}");
         response.Success.Should().BeFalse();
@@ -277,7 +277,7 @@ public async Task GetAllProjectsAsync_GettingConnectionConfigurationSLCoreServic
     [TestMethod]
     public async Task GetAllProjectsAsync_ConnectionToSonarQubeWithToken_CallsGetAllProjectsAsyncWithCorrectParams()
     {
-        await testSubject.GetAllProjectsAsync(SonarQubeConnection);
+        await testSubject.GetAllProjectsAsync(sonarQubeConnection);
 
         await connectionConfigurationSlCoreService.Received(1)
             .GetAllProjectsAsync(Arg.Is<GetAllProjectsParams>(x => IsExpectedSonarQubeConnectionParams(x.transientConnection, ValidToken.UserName)));
@@ -288,9 +288,9 @@ public async Task GetAllProjectsAsync_ConnectionToSonarQubeWithCredentials_Calls
     {
         const string username = "username";
         const string password = "password";
-        SonarQubeConnection.Credentials = new BasicAuthCredentials(username, password.CreateSecureString());
+        sonarQubeConnection.Credentials = new BasicAuthCredentials(username, password.CreateSecureString());
         
-        await testSubject.GetAllProjectsAsync(SonarQubeConnection);
+        await testSubject.GetAllProjectsAsync(sonarQubeConnection);
 
         await connectionConfigurationSlCoreService.Received(1)
             .GetAllProjectsAsync(Arg.Is<GetAllProjectsParams>(x => IsExpectedSonarQubeConnectionParams(x.transientConnection, username, password)));
@@ -299,7 +299,7 @@ await connectionConfigurationSlCoreService.Received(1)
     [TestMethod]
     public async Task GetAllProjectsAsync_ConnectionToSonarCloudWithToken_CallsGetAllProjectsAsyncWithCorrectParams()
     {
-        await testSubject.GetAllProjectsAsync(SonarCloudConnection);
+        await testSubject.GetAllProjectsAsync(sonarCloudConnection);
 
         await connectionConfigurationSlCoreService.Received(1)
             .GetAllProjectsAsync(Arg.Is<GetAllProjectsParams>(x => IsExpectedSonarCloudConnectionParams(x.transientConnection, ValidToken.UserName)));
@@ -310,9 +310,9 @@ public async Task GetAllProjectsAsync_ConnectionToSonarCloudWithCredentials_Call
     {
         const string username = "username";
         const string password = "password";
-        SonarCloudConnection.Credentials = new BasicAuthCredentials(username, password.CreateSecureString());
+        sonarCloudConnection.Credentials = new BasicAuthCredentials(username, password.CreateSecureString());
 
-        await testSubject.GetAllProjectsAsync(SonarCloudConnection);
+        await testSubject.GetAllProjectsAsync(sonarCloudConnection);
 
         await connectionConfigurationSlCoreService.Received(1)
             .GetAllProjectsAsync(Arg.Is<GetAllProjectsParams>(x => IsExpectedSonarCloudConnectionParams(x.transientConnection, username, password)));
@@ -324,7 +324,7 @@ public async Task GetAllProjectsAsync_ReturnsResponseFromSlCore()
         List<SonarProjectDto> expectedServerProjects = [CreateSonarProjectDto("projKey1", "projName1"), CreateSonarProjectDto("projKey2", "projName2")];
         connectionConfigurationSlCoreService.GetAllProjectsAsync(Arg.Any<GetAllProjectsParams>()).Returns(new GetAllProjectsResponse(expectedServerProjects));
 
-        var response = await testSubject.GetAllProjectsAsync(SonarCloudConnection);
+        var response = await testSubject.GetAllProjectsAsync(sonarCloudConnection);
 
         response.Success.Should().BeTrue();
         response.ResponseData.Count.Should().Be(expectedServerProjects.Count);
@@ -340,7 +340,7 @@ public async Task GetServerProjectByKeyAsync_SwitchesToBackgroundThread()
         var threadHandlingMock = Substitute.For<IThreadHandling>();
         var slCoreConnectionAdapter = new SlCoreConnectionAdapter(slCoreServiceProvider, threadHandlingMock, logger);
 
-        await slCoreConnectionAdapter.GetServerProjectByKeyAsync(SonarCloudConnection, "server-project-key");
+        await slCoreConnectionAdapter.GetServerProjectByKeyAsync(sonarCloudConnection, "server-project-key");
 
         await threadHandlingMock.Received(1).RunOnBackgroundThread(Arg.Any<Func<Task<AdapterResponseWithData<ServerProject>>>>());
     }
@@ -350,7 +350,7 @@ public async Task GetServerProjectByKeyAsync_GettingConnectionConfigurationSLCor
     {
         slCoreServiceProvider.TryGetTransientService(out IConnectionConfigurationSLCoreService _).Returns(false);
 
-        var response = await testSubject.GetServerProjectByKeyAsync(SonarCloudConnection, "server-project-key");
+        var response = await testSubject.GetServerProjectByKeyAsync(sonarCloudConnection, "server-project-key");
 
         logger.Received(1).LogVerbose($"[{nameof(IConnectionConfigurationSLCoreService)}] {SLCoreStrings.ServiceProviderNotInitialized}");
         response.Success.Should().BeFalse();
@@ -364,7 +364,7 @@ public async Task GetServerProjectByKeyAsync_SlCoreThrowsException_ReturnsFailed
         connectionConfigurationSlCoreService.When(x => x.GetProjectNamesByKeyAsync(Arg.Any<GetProjectNamesByKeyParams>()))
             .Do(_ => throw new Exception(exceptionMessage));
 
-        var response = await testSubject.GetServerProjectByKeyAsync(SonarCloudConnection, "server-project-key");
+        var response = await testSubject.GetServerProjectByKeyAsync(sonarCloudConnection, "server-project-key");
 
         logger.Received(1).LogVerbose($"{Resources.GetServerProjectByKey_Fails}: {exceptionMessage}");
         response.Success.Should().BeFalse();
@@ -378,7 +378,7 @@ public async Task GetServerProjectByKeyAsync_ProjectNotFound_ReturnsFailedRespon
         connectionConfigurationSlCoreService.GetProjectNamesByKeyAsync(Arg.Any<GetProjectNamesByKeyParams>())
             .Returns(new GetProjectNamesByKeyResponse(slCoreResponse));
         
-        var response = await testSubject.GetServerProjectByKeyAsync(SonarCloudConnection, "project-key");
+        var response = await testSubject.GetServerProjectByKeyAsync(sonarCloudConnection, "project-key");
 
         response.Success.Should().BeFalse();
         response.ResponseData.Should().BeNull();
@@ -393,7 +393,7 @@ public async Task GetServerProjectByKeyAsync_ProjectFound_ReturnsSuccessResponse
         };
         connectionConfigurationSlCoreService.GetProjectNamesByKeyAsync(Arg.Any<GetProjectNamesByKeyParams>())
             .Returns(new GetProjectNamesByKeyResponse(slCoreResponse));
-        var response = await testSubject.GetServerProjectByKeyAsync(SonarQubeConnection, "project-key");
+        var response = await testSubject.GetServerProjectByKeyAsync(sonarQubeConnection, "project-key");
 
         response.Success.Should().BeTrue();
         response.ResponseData.Should().BeEquivalentTo(new ServerProject("project-key", "project-name"));
@@ -407,7 +407,7 @@ public async Task GetAllProjectsAsync_SlCoreValidationThrowsException_ReturnsUns
         connectionConfigurationSlCoreService.When(x => x.GetAllProjectsAsync(Arg.Any<GetAllProjectsParams>()))
             .Do(_ => throw new Exception(exceptionMessage));
 
-        var response = await testSubject.GetAllProjectsAsync(SonarCloudConnection);
+        var response = await testSubject.GetAllProjectsAsync(sonarCloudConnection);
 
         logger.Received(1).LogVerbose($"{Resources.GetAllProjects_Fails}: {exceptionMessage}");
         response.Success.Should().BeFalse();

From d91ecb1db4d9854f54f8295682c365c43a9f8051 Mon Sep 17 00:00:00 2001
From: Gabriela Trutan <gabriela.trutan@sonarsource.com>
Date: Wed, 25 Sep 2024 14:23:04 +0200
Subject: [PATCH 09/10] SLVS-1448 Update wrong id in test to prevent confusion

---
 .../UI/ManageConnections/ManageConnectionsViewModelTest.cs      | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/ConnectedMode.UnitTests/UI/ManageConnections/ManageConnectionsViewModelTest.cs b/src/ConnectedMode.UnitTests/UI/ManageConnections/ManageConnectionsViewModelTest.cs
index 2fb4c1f03a..0688c643af 100644
--- a/src/ConnectedMode.UnitTests/UI/ManageConnections/ManageConnectionsViewModelTest.cs
+++ b/src/ConnectedMode.UnitTests/UI/ManageConnections/ManageConnectionsViewModelTest.cs
@@ -47,7 +47,7 @@ public void TestInitialize()
         twoConnections =
         [
             new Connection(new ConnectionInfo("http://localhost:9000", ConnectionServerType.SonarQube), true),
-            new Connection(new ConnectionInfo("https://sonarcloud.io/organizations/myOrg", ConnectionServerType.SonarCloud), false)
+            new Connection(new ConnectionInfo("myOrg", ConnectionServerType.SonarCloud), false)
         ];
         progressReporterViewModel = Substitute.For<IProgressReporterViewModel>();
         connectedModeServices = Substitute.For<IConnectedModeServices>();

From 2a2c84caf849accf1ea69f1e04038756154842ae Mon Sep 17 00:00:00 2001
From: Gabriela Trutan <gabriela.trutan@sonarsource.com>
Date: Wed, 25 Sep 2024 14:40:22 +0200
Subject: [PATCH 10/10] SLVS-1448  Fix failing unit tests

---
 .../UI/ManageConnections/ManageConnectionsViewModelTest.cs      | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/ConnectedMode.UnitTests/UI/ManageConnections/ManageConnectionsViewModelTest.cs b/src/ConnectedMode.UnitTests/UI/ManageConnections/ManageConnectionsViewModelTest.cs
index 0688c643af..815b6bd1f1 100644
--- a/src/ConnectedMode.UnitTests/UI/ManageConnections/ManageConnectionsViewModelTest.cs
+++ b/src/ConnectedMode.UnitTests/UI/ManageConnections/ManageConnectionsViewModelTest.cs
@@ -46,7 +46,7 @@ public void TestInitialize()
     {
         twoConnections =
         [
-            new Connection(new ConnectionInfo("http://localhost:9000", ConnectionServerType.SonarQube), true),
+            new Connection(new ConnectionInfo(new Uri("http://localhost:9000").ToString(), ConnectionServerType.SonarQube), true),
             new Connection(new ConnectionInfo("myOrg", ConnectionServerType.SonarCloud), false)
         ];
         progressReporterViewModel = Substitute.For<IProgressReporterViewModel>();