Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prealpha] Obsidian LavaShortcodeDetail Documentation field defaults to code editor if shortcode syntax is present #6041

Open
2 tasks done
leahjennings opened this issue Oct 20, 2024 · 1 comment
Labels
Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Type: Bug Confirmed bugs or reports that are very likely to be bugs.

Comments

@leahjennings
Copy link
Collaborator

Description

If you add shortcode syntax ({[ ]}) to the Documentation field in the new Obsidian LavaShortcodeDetail block, then when you go to edit the shortcode it defaults to Code Editor without allowing it to show the visual editor.
Before save:
image

After save:
image

I often use this Documentation field for quick copy/paste references on how to use the shortcode.

Actual Behavior

The visual editor doesn't show if there is any shortcode syntax ({[ ]}) present.

Expected Behavior

I would expect that using shortcode syntax in the Documentation field would show the rendered output in the visual editor (the non-Obsidian block did).

Steps to Reproduce

  • On the prealpha site, go to Settings, then click on Lava Shortcodes
  • Click the + icon to create a new shortcode
  • Name it test, make the shortcode test, mark it inline, and put test in the shortcode markup (this is irrelevant but they are required fields)
image
  • In the Documentation field, add the shortcode syntax: {[ test ]}
image
  • Save the shortcode
  • Find the shortcode in the list and open it, then click Edit
  • Notice how the Documentation field only shows code editor without the ability to switch to visual editor
image

Issue Confirmation

  • Perform a search on the Github Issues to see if your bug or enhancement is already reported.
  • Reproduced the problem on a fresh install or on the demo site.

Rock Version

Rock McKinley 17.0 (1.17.0.30)

Client Culture Setting

en-US

@sparkdevnetwork-service sparkdevnetwork-service added Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Type: Bug Confirmed bugs or reports that are very likely to be bugs. labels Oct 21, 2024
@chead4
Copy link

chead4 commented Oct 21, 2024

@leahjennings Thank you for reporting the issue Leah!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Type: Bug Confirmed bugs or reports that are very likely to be bugs.
Projects
None yet
Development

No branches or pull requests

3 participants