-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Script has weak SAS parsing logic [HELP WANTED] #17
Comments
You're using a SAS drive, and this tool has weak support for SAS drives -- because I don't own any to test with. |
Alright, I'll do a fork and see if I can adapt it to handle SAS disks better. I currently only have the one model, but depending on how these go I may have others soon. I'll also change the title of this issue to reflect the problem, and it would be nice if you added a help-wanted label so we could see about getting others involved with a variety of models. |
Seems I worked on that without noticing there is this open issue: I'll use this chance to say thank you @Spearfoot for saving me lots of time. I was just about to hack a little script together to burnin and log information on my 15 heterogenous drives, but you already invented that wheel in a nice and clean way. <3 |
Closed since work is already being done on #22 |
It appears the issue is relating to weak logic surrounding SAS models. However, more test cases should be provided to confirm if this is indeed a protocol difference, or a difference in how manufacturers report SMART data.
It appears the script is incorrectly parsing smartctl results, as the script reports the following:
but
sudo smartctl --all /dev/sda
clearly shows the expected dataExpected behavior:
Correctly parse the results of smartctl so the script can function accordingly.
The text was updated successfully, but these errors were encountered: