Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SharpHoundCommon and SharpHoundRPC Version Mismatch in Sharphound.csproj #125

Open
shogunlab opened this issue Dec 11, 2024 · 2 comments
Open

Comments

@shogunlab
Copy link

Hey there. I noticed that in previous SharpHoundCommon version bump commits such as 0dff518 and a18a982, both SharpHoundCommon and SharpHoundRPC package references receive a version bump in the Sharphound.csproj file. But, in the commit 64ef0e5, only SharpHoundCommon is updated to 4.0.9 while SharpHoundRPC remains on 4.0.8.

Was this intentional? If not, would it make sense to bump the SharpHoundRPC version in the package reference as well? If it was intentional, please feel free to close this issue and disregard. Thank you!

@rvazarkar
Copy link
Contributor

Its not intentional, but it's also not going to affect anything. The RPC library hasn't received any updates in a significant period of time. At some point, I'll look into making the RPC library a pinned version along with the CommonLib. I'll make sure to update it in an upcoming MR, or if you'd like to make an MR for it, feel free and I'll accept it :)

@shogunlab
Copy link
Author

Sounds good! Thank you for clarifying. Then yeah, I'll submit a pull request with an update to have the SharpHoundRPC version bumped to 4.0.9 in the 2.X branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants