Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Resource get URLS return HTML webpage instead of valid .jar plugin file #45

Closed
bjornpijnacker opened this issue Dec 12, 2021 · 2 comments

Comments

@bjornpijnacker
Copy link

As the title names, some get requests to https://api.spiget.org/v2/resources/{plugin_id}/download return the HTML download page for the plugin instead of the plugin's .jar file. Example IDs for which this occurs is 9089 (EssentialsX) and 274 (DynMap).

@InventivetalentDev
Copy link
Member

both of those resources are hosted on external sites, hence the broken download. see #20 #27

@Th3Shadowbroker
Copy link

Th3Shadowbroker commented Dec 13, 2021

Hey there,
I were able to replicate the described behaviour. However both of the plugins you've named link to an external download page or at least their current version does. As these pages vary for each plugin, individual web-crawling is impossible. I've checked the request via postman and SpiGet responds with a 302 - Found. I think, that such a response should be handled on the client side as the API response matches its documentation.

EDIT: Didn't saw the reply until GitHub reloaded when posting the comment 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants