This repository has been archived by the owner on May 14, 2020. It is now read-only.
Fix FP in 941130 and rearrange regex with new regex-assemble file #1701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgsch
reviewed
Feb 26, 2020
Comment on lines
6
to
8
| (?i)[\s\S]data:text\/html\b | ||
| (?i)[\s\S]formaction\b | ||
| (?i)[\s\S]\@import\b |
There was a problem hiding this comment.
Would you mind dropping the escape for / and @?
There was a problem hiding this comment.
Sure thing. We did not care enough to fix it initially. Good you noticed....
|
LGTM now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1582.
This was done during the 4th CRS / ModSecurity Meetup in Bern (participants: @franbuehler, @theseion, @zugao, @srueg, @dune73 and Roger and Marc).
The fix is done on the fact that the base64 string is only useful as an exploit within inline encoding of payloads via base64 and that always starts with
;base64. We have thus put a semicolon in front.See for example: https://www.bigfastblog.com/embed-base64-encoded-images-inline-in-html
Then we rearranged the slightly odd regex with the help of a new regexp-assemble data file.