Two side probe integration. #382
Open
+146
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
alejoe91
reviewed
Nov 12, 2025
alejoe91
reviewed
Nov 12, 2025
h-mayorquin
reviewed
Nov 20, 2025
Collaborator
h-mayorquin
left a comment
h-mayorquin
left a comment
There was a problem hiding this comment.
I guess without this there would be another way:
| Limits for z dimension | ||
| show_channel_on_click : bool, default: False | ||
| If True, the channel information is shown upon click | ||
| side : None | "front" | "back" |
Collaborator
There was a problem hiding this comment.
I kind of think that I would not know what to expect between front and back or left or right? Both of them seem equally arbitrary, maybe we should type with literal so this surfaces to end users in docstrings more directly.
Member
Author
There was a problem hiding this comment.
In my mind, the manufacturer define the official front and back.
Wre could also put A and B like in good old time for audio tapes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@WeissShahaf @alejoe91
See SpikeInterface/probeinterface_library#9