Bump JDK, Kotlin, Gradle, and local dependencies #1577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... until SpineEventEngine/validation#201 is addressed.
Also: * Stop implementing `BiFunction`. * Add missing generic parameter `I` in params of `EntityState<*>`.
1. Filter `CallerProvider` itself. 2. Skip calls from the module `java.base`.
Also: * Make methods static.
alexander-yevsyukov
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1577 +/- ##
============================================
- Coverage 90.73% 90.51% -0.22%
- Complexity 5008 5012 +4
============================================
Files 645 644 -1
Lines 15640 15658 +18
Branches 939 941 +2
============================================
- Hits 14191 14173 -18
- Misses 1110 1149 +39
+ Partials 339 336 -3 🚀 New features to boost your workflow:
|
armiol
approved these changes
Mar 28, 2025
Contributor
armiol
left a comment
armiol
left a comment
There was a problem hiding this comment.
@alexander-yevsyukov LGTM with a minor comment.
server/build.gradle.kts
Outdated
| from(sourceSets.testFixtures.get().output) | ||
| } | ||
| } | ||
|
|
yevhenii-nadtochii
approved these changes
Mar 28, 2025
| * @see RoutingMap | ||
| */ | ||
| internal sealed class RoutingMethod<I: Any, M: Message, C: Message, R: Any>( | ||
| internal sealed class RoutingMethod<I: Any, M: Routable, C: SignalContext, R: Any>( |
There was a problem hiding this comment.
Suggested change
| internal sealed class RoutingMethod<I: Any, M: Routable, C: SignalContext, R: Any>( | |
| internal sealed class RoutingMethod<I : Any, M : Routable, C : SignalContext, R : Any>( |
| ) { | ||
| override fun self(): StateUpdateRouting<I> = this | ||
|
|
||
|
|
| private const val TESTING_SERVER_PACKAGE = "io.spine.testing.server" | ||
|
|
||
| /** | ||
| * Throws [SecurityException] of the calling class does not belong to |
There was a problem hiding this comment.
Suggested change
| * Throws [SecurityException] of the calling class does not belong to | |
| * Throws [SecurityException] if the calling class does not belong to |
| return result | ||
| } | ||
|
|
||
| private fun nonAllowedCaller(callingClass: Class<*>): SecurityException { |
There was a problem hiding this comment.
Suggested change
| private fun nonAllowedCaller(callingClass: Class<*>): SecurityException { | |
| private fun notAllowedCaller(callingClass: Class<*>): SecurityException { |
I have not seen non allowed before. You can save on braces here.
| /** | ||
| * Test environment repository for {@linkplain AggregateTest | ||
| * Aggregate tests}. | ||
| * Test environment repository for Aggregate tests}. |
There was a problem hiding this comment.
Suggested change
| * Test environment repository for Aggregate tests}. | |
| * Test environment repository for Aggregate tests. |
| option java_package = "io.spine.test.server.envelope"; | ||
| option java_multiple_files = true; | ||
|
|
||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps major external and local dependencies and introduce changes described in the sections below.
Changes in the routing code
RouteFnno longer extends Kotlin'sFunction2, which avoids automatic conversion of the derived types performed by the newer Kotlin compiler . The conversion caused casting problems both in production and testing code.EventRouting.unicast()function which acceptedBiFunctionwas removed.@FunctionalInterfaceannotations were removed on types extendingRouteFn. This did not cause any problems with existing Java routing functions.Other notable changes
servermodule were separated in thetestFixturessource set.null-ness check inFilterMixinTestback because the generated code now supports it.io.spine.server.securitypackage was converted to Kotlin. Also, the deprecatedSecurityManagerJava API is no longer used.? extends @Nullable Object.@Routeannotation was updated to mention generated routing setup classes.