Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create metadata keys and contexts with LoggingContextFactory #72

Open
yevhenii-nadtochii opened this issue Oct 5, 2023 · 0 comments
Open

Comments

@yevhenii-nadtochii
Copy link
Collaborator

This issue is a suggestion.

Now, metadata keys are created with LoggingFactory that also creates loggers.

To create a new context, one should use ScopedLoggingContext.newContext().

However, we have LoggingContextFactory that creates level maps and contexts. But it is internal.

Metadata keys strictly relate to the context. So, I suggest moving keys and context creation to LoggingContextFactory, and make this factory public.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant