Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement support for Comparable messages #152

Closed
alexander-yevsyukov opened this issue Aug 10, 2024 · 0 comments · Fixed by #154
Closed

Implement support for Comparable messages #152

alexander-yevsyukov opened this issue Aug 10, 2024 · 0 comments · Fixed by #154
Assignees
@yevhenii-nadtochii
Labels
enhancement New feature or request

Comments

@alexander-yevsyukov
Copy link
Contributor

Sometime ago we introduced an option for making generated message types Comparable. Now we only have the option called CompareByOption with no code generation support for it.

McJava should be extended to support comparison of message types according to the option, if it's defined in a message type.
@alexander-yevsyukov alexander-yevsyukov added the enhancement New feature or request label Aug 10, 2024
@alexander-yevsyukov alexander-yevsyukov changed the title Implement support for comparable messages Implement support for Comparable messages Aug 10, 2024
@armiol armiol moved this to 📋 Backlog in v2.0 Aug 19, 2024
@yevhenii-nadtochii yevhenii-nadtochii moved this from 📋 Backlog to 🏗 In progress in v2.0 Aug 22, 2024
@yevhenii-nadtochii yevhenii-nadtochii linked a pull request Aug 27, 2024 that will close this issue
Handle compare_by option #154
Merged
@yevhenii-nadtochii yevhenii-nadtochii mentioned this issue Sep 6, 2024
Merged
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in v2.0 Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yevhenii-nadtochii yevhenii-nadtochii

Labels
enhancement New feature or request
Projects
v2.0
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle compare_by option SpineEventEngine/mc-java
2 participants
@alexander-yevsyukov @yevhenii-nadtochii