Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine structure of ConstraintViolation #177

Open
yevhenii-nadtochii opened this issue Dec 27, 2024 · 0 comments
Open

Refine structure of ConstraintViolation #177

yevhenii-nadtochii opened this issue Dec 27, 2024 · 0 comments

Comments

@yevhenii-nadtochii
Copy link
Contributor

Currently, this type has the following nuances to resolve:

  1. string format and repeated string param fields should be removed in favor of TemplateString message.
  2. base.FieldPath field_path is mostly used as field_name. Let's introduce an explicit field_name, and remove the remaining path prefix to field_path_prefix field.
  3. repeated violation field is unnecessary. Currently, we create two violations where a single one actually occurs. If a nested message has an invalid field, a root message always creates an unnecessary violation as a wrapper. We should try to avoid this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant