Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spring.boot.web notation #611

Merged
merged 1 commit into from
Sep 18, 2022
Merged

Add Spring.boot.web notation #611

merged 1 commit into from
Sep 18, 2022

Conversation

Gounlaf
Copy link
Contributor

@Gounlaf Gounlaf commented Sep 16, 2022

Hello/bonjour,

What?

Resolves #610

Testing?

CI Errors are not related to my changes (if I'm right)

@LouisCAD
Copy link
Member

Hi, they are. Please look at the contributing guide on our website.

@Gounlaf Gounlaf force-pushed the GH-610 branch 2 times, most recently from fc7efac to 178b92c Compare September 17, 2022 10:55
@Gounlaf
Copy link
Contributor Author

Gounlaf commented Sep 18, 2022

@LouisCAD can you confirm me I need to rebase and remove some file because of #614 ?

@LouisCAD
Copy link
Member

LouisCAD commented Sep 18, 2022

@Gounlaf Yes, the exact steps for you to follow are:

  1. Undo commit (keeping your changes)
  2. Remove the changes to the docs/dependencies-notations.md file
  3. Update/rebase your branch
  4. Commit back
  5. Force-push

@Gounlaf
Copy link
Contributor Author

Gounlaf commented Sep 18, 2022

@Gounlaf Yes, the exact steps for you to follow are:

1. Undo commit (keeping your changes)
2. Remove the changes to the `docs/dependencies-notations.md` file
3. Update/rebase your branch
4. Commit back
5. Force-push

@LouisCAD Thanks for your quick answer. It sould be ok.

@LouisCAD LouisCAD merged commit b6f983d into Splitties:main Sep 18, 2022
@LouisCAD
Copy link
Member

It is, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency notations for Spring Boot Starter Web
3 participants