Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skulls deserialized from 1.20.6 -> 1.21 lose skin #4123

Open
SamB440 opened this issue Aug 14, 2024 · 1 comment
Open

Skulls deserialized from 1.20.6 -> 1.21 lose skin #4123

SamB440 opened this issue Aug 14, 2024 · 1 comment
Labels
status: needs triage This label is automatically applied to new issues and pull requests to indicate they require triage type: bug Something isn't working

Comments

@SamB440
Copy link
Contributor

SamB440 commented Aug 14, 2024

Affected Product(s)

SpongeVanilla

Version

1.21.1-12.0.0-RC1784

Operating System

Linux

Java Version

21

Plugins/Mods

Plugins (18)
Minecraft v1.21.1
SpongeAPI v12.0.0-SNAPSHOT
Sponge v1.21.1-12.0.0-SNAPSHOT
SpongeVanilla v1.21.1-12.0.0-RC1784
LemonadeStand v1.0.1-SNAPSHOT
WorldEdit v7.3.7-SNAPSHOT+6896-6e37730
LemonSqueezer v1.0.1-SNAPSHOT
LuckPerms v5.4.139
spark-sponge8 v1.10.93
Treaty v1.0.0
NuVotifier v3.0.0-SNAPSHOT+9d69da2
ViaVersion v1.0.1
Orbis v1.0.0-SNAPSHOT
PacketEvents v2.5.0+e0b9d6813-SNAPSHOT
Spelare v1.0.1-SNAPSHOT
Pharus v1.0.0-SNAPSHOT
Masquerade v1.0.2-SNAPSHOT
Battlegrounds v3.1.2

Describe the bug

Deserializing a skull in 1.21 with

final DataContainer read = DataFormats.NBT.get().readFrom(inputStream);
// Deserialize to item stack
return Sponge.dataManager().deserialize(ItemStack.class, read).orElseThrow();

that was serialized in 1.20.6 results in it losing its skin.

Link to logs

No response

@SamB440 SamB440 added status: needs triage This label is automatically applied to new issues and pull requests to indicate they require triage type: bug Something isn't working labels Aug 14, 2024
@SamB440
Copy link
Contributor Author

SamB440 commented Aug 17, 2024

In addition, there seem to be some other item upgrade issues, items with attribute modifiers seem to have been stripped of them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs triage This label is automatically applied to new issues and pull requests to indicate they require triage type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant