code cleanup

Author: grahamboree

src/DarkConfig/Internal/ReflectionCache.cs

@@ -276,11 +276,11 @@ TypeInfo CacheTypeInfo(Type type) {
 
             // if type is a union, register it with its base type
             if (typeUnionKey != null) {
-                if (type.BaseType == typeof(Object) || type.BaseType == null) {
+                if (type.BaseType == typeof(object) || type.BaseType == null) {
                     throw new Exception($"Type {type.Name} has ConfigUnion but is not a child type");
                 }
-                TypeInfo parentInfo = GetTypeInfo(type.BaseType);
-                parentInfo.UnionKeys ??= new MultiCaseDictionary<Type>();
+                var parentInfo = GetTypeInfo(type.BaseType);
+                parentInfo.UnionKeys ??= new();
 
                 if (!parentInfo.UnionKeys.TryAdd(typeUnionKey, type)) {
                     throw new Exception($"Type {type.Name} has ConfigUnion with duplicate key {typeUnionKey}");

src/DarkConfig/Internal/TypeReifier.cs

@@ -20,7 +20,7 @@ public TypeReifier() {
             RegisteredFromDocs[typeof(TimeSpan)] = BuiltInTypeReifiers.FromTimeSpan;
         }
 
-        internal class ReificationResult {
+        class ReificationResult {
             internal bool ShouldVerifyMemberHashes;
             internal readonly List<int> SetMemberHashes = new List<int>();
 
@@ -122,7 +122,7 @@ public void SetStaticMembers(Type type, DocNode doc, ReificationOptions options)
             }
 
             // Check whether any required members in the type were not set.
-            if (missingRequiredMemberNames != null && missingRequiredMemberNames.Count > 0) {
+            if (missingRequiredMemberNames is {Count: > 0}) {
                 throw new MissingFieldsException(type, doc, $"Missing doc fields: {JoinList(missingRequiredMemberNames, ", ")}");
             }
 
@@ -280,7 +280,7 @@ public bool SetFieldOnStruct<T>(ref T obj, string fieldName, DocNode doc, Reific
                         }
 
                         // Figure out the size of each dimension the array.
-                        var lengths = new int[rank];
+                        int[] lengths = new int[rank];
                         var currentArray = doc;
                         for (int dimensionIndex = 0; dimensionIndex < rank; ++dimensionIndex) {
                             lengths[dimensionIndex] = currentArray.Count;
@@ -327,8 +327,8 @@ void ReadArray(DocNode current, int currentRank) {
                             for (int i = 0; i < current.Count; ++i) {
                                 currentIndex[currentRank] = i;
                                 if (currentRank == rank - 1) {
-                                    var existingElement = arrayValue.GetValue(currentIndex);
-                                    var updatedElement = ReadValueOfType(elementType, existingElement, current[i], options);
+                                    object? existingElement = arrayValue.GetValue(currentIndex);
+                                    object? updatedElement = ReadValueOfType(elementType, existingElement, current[i], options);
                                     arrayValue.SetValue(updatedElement, currentIndex);
                                 } else {
                                     ReadArray(current[i], currentRank + 1);