Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Core model to remove UI things #180

Open
wwaites opened this issue Jun 17, 2024 · 0 comments
Open

Refactor Core model to remove UI things #180

wwaites opened this issue Jun 17, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@wwaites
Copy link

wwaites commented Jun 17, 2024

The core model is said to be the foundation upon which domain models are built. However, it contains a lot of things like,

:height
    a owl:DatatypeProperty ;
    rdfs:comment "The height of an asset group in the UI" ;
    rdfs:domain :AssetGroup ;
    rdfs:label "hasHeight" ;
    rdfs:range xsd:integer .

:hidden
    a owl:DatatypeProperty ;
    rdfs:comment "Whether a relation is hidden from the UI entirely. This is different from being invisible: a relation is visible (on the canvas) iff both its source and target asset are visible. A hidden relation is *never* visible; neither on the canvas nor anywhere else. This normally applies to relations that are used internally by the validator. All hidden relations are also immutable (by the user)." ;
    rdfs:domain owl:ObjectProperty ;
    rdfs:label "hidden" ;
    rdfs:range xsd:boolean ;
    rdfs:subPropertyOf :immutable .

:isCalculatingRisk
    a owl:DatatypeProperty ;
    rdfs:comment "Whether the risk calculation for this model is currently running" ;
    rdfs:label "isCalculatingRisk" ;
    rdfs:range xsd:boolean .

whilst these predicates certainly belong somewhere, that place would seem to be somewhere that is not the core model.

@kenmeacham kenmeacham added the enhancement New feature or request label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants