issue while trying to run counter_example & stac_gallery - (outdated AGP/KGP)

[r4khul]

Description

counter_example & stac_gallery seems outdated and they are using groovy DSL

Logs:

1. counter_example:

Warning: Flutter support for your project's Android Gradle Plugin version (Android Gradle Plugin version 8.1.0) will soon be dropped. Please upgrade your Android Gradle Plugin version to a version of at least Android Gradle Plugin version 8.1.1 soon.
Alternatively, use the flag "--android-skip-build-dependency-validation" to bypass this check.

Potential fix: Your project's AGP version is typically defined in the plugins block of the settings.gradle file (/home/rakhul/opensource/stac/examples/counter_example/android/settings.gradle), by a plugin with the id of com.android.application.

2. stac_gallery:

Warning: Flutter support for your project's Kotlin version (1.8.22) will soon be dropped. Please upgrade your Kotlin version to a version of at least 2.1.0 soon.
Alternatively, use the flag "--android-skip-build-dependency-validation" to bypass this check.

Potential fix: Your project's KGP version is typically defined in the plugins block of the settings.gradle file (/home/rakhul/opensource/stac/examples/stac_gallery/android/settings.gradle), by a plugin with the id of org.jetbrains.kotlin.android.

Requirements

• bump upgrade the versions to as per the ask to keep it consistent with newest version

[r4khul]

actually ig we can just migrate this completely to kotlin DSL itself since this is jus a example ( prolly no breakin change is gonna happen )

• i dropped the older android folder & created a new android platform release (kotlin DSL) for counter_example

and everything runs smoothly now

[divyanshub024]

@coderabbitai plan

[coderabbitai]

Coding Plan

Summary

• Upgrade counter_example's AGP from 8.1.0 to 8.7.3 and KGP from 1.8.22 to 2.1.0, with Gradle wrapper updated from 8.3 to 8.9 to meet AGP compatibility requirements
• Upgrade stac_gallery's KGP from 1.8.22 to 2.1.0 while preserving its existing AGP 8.7.3 and Gradle 8.9 configuration
• Both examples retain their Groovy DSL format as conversion to Kotlin DSL was not requested
• Final configurations align with movie_app's plugin versions (AGP 8.7.3, KGP 2.1.0) while maintaining appropriate Gradle versions for each project's configuration style

Design Choices

Design Choice 1: Should counter_example's KGP also be upgraded alongside AGP?

Options Considered:

1. Only upgrade AGP in counter_example as explicitly mentioned in the ticket
2. Upgrade both AGP and KGP in counter_example for consistency with movie_app

Chosen Option: 2

Rationale: Upgrading both ensures consistency across examples and prevents a similar KGP deprecation warning from appearing in counter_example in the future.

Design Choice 2: What Gradle wrapper version should counter_example use after AGP upgrade?

Options Considered:

1. Use Gradle 8.9 (minimum required for AGP 8.7.x, matches stac_gallery)
2. Use Gradle 8.12 (matches movie_app, the newest example)

Chosen Option: 1

Rationale: Gradle 8.9 meets the AGP 8.7.x requirement and maintains similarity with stac_gallery's Groovy DSL configuration, minimizing unnecessary divergence.

💡 User Tips

Regenerate the plan with different choices with @coderabbitai <feedback>.

Implementation Steps

Phase 1: Update counter_example Android Build Configuration

This phase addresses the AGP deprecation warning in counter_example by upgrading AGP from 8.1.0 to 8.7.3, along with necessary dependency updates (Gradle wrapper and KGP) to ensure compatibility and consistency.

Task 1: Upgrade Plugin Versions in counter_example settings.gradle

Update the plugin version declarations to match current standards and resolve the Flutter deprecation warning.

• Update examples/counter_example/android/settings.gradle to change AGP version from 8.1.0 to 8.7.3 in the plugins block (line 21)
• Update the same file to change KGP version from 1.8.22 to 2.1.0 in the plugins block (line 22)

Task 2: Upgrade Gradle Wrapper Version in counter_example

Update the Gradle wrapper to meet AGP 8.7.x minimum requirements (Gradle 8.9+).

• Update examples/counter_example/android/gradle/wrapper/gradle-wrapper.properties to change distribution URL from gradle-8.3-all.zip to gradle-8.9-all.zip

🤖 Prompt for AI agents

This phase upgrades counter_example's Android build configuration to resolve
Flutter deprecation warnings by updating AGP from 8.1.0 to 8.7.3, KGP from
1.8.22 to 2.1.0, and Gradle wrapper from 8.3 to 8.9.

**Plugin Version Updates:**
- In `examples/counter_example/android/settings.gradle`, locate the plugins
block (around line 21-22)
- Update the Android Gradle Plugin (AGP) version from 8.1.0 to 8.7.3
- Update the Kotlin Gradle Plugin (KGP) version from 1.8.22 to 2.1.0
- Preserve the existing Groovy DSL format

**Gradle Wrapper Update:**
- In `examples/counter_example/android/gradle/wrapper/gradle-wrapper.properties`
- Update the distributionUrl from gradle-8.3-all.zip to gradle-8.9-all.zip
- This ensures compatibility with AGP 8.7.x which requires Gradle 8.9 minimum

Phase 2: Update stac_gallery Android Build Configuration

This phase addresses the KGP deprecation warning in stac_gallery by upgrading KGP from 1.8.22 to 2.1.0.

Upgrade Kotlin Plugin Version in stac_gallery settings.gradle

Update the Kotlin Gradle Plugin version to resolve the Flutter deprecation warning.

• Update examples/stac_gallery/android/settings.gradle to change KGP version from 1.8.22 to 2.1.0 in the plugins block (line 22, the org.jetbrains.kotlin.android plugin declaration)

🤖 Prompt for AI agents

This phase upgrades stac_gallery's Kotlin Gradle Plugin to resolve Flutter
deprecation warnings by updating KGP from 1.8.22 to 2.1.0.

**Plugin Version Update:**
- In `examples/stac_gallery/android/settings.gradle`, locate the plugins block
(around line 22)
- Update the `org.jetbrains.kotlin.android` plugin version from 1.8.22 to 2.1.0
- Preserve the existing Groovy DSL format
- Do not modify the AGP version (already at 8.7.3) or Gradle wrapper version
(already at 8.9)

Research

The repository contains three Flutter example projects with Android configurations. movie_app uses the most modern setup (AGP 8.7.3, KGP 2.1.0, Gradle 8.12), while counter_example (AGP 8.1.0, KGP 1.8.22, Gradle 8.3) and stac_gallery (AGP 8.7.3, KGP 1.8.22, Gradle 8.9) have outdated dependencies. All three use the plugins DSL in settings.gradle for version declarations. counter_example and stac_gallery use Groovy DSL while movie_app uses Kotlin DSL.

---

🚀 Next Steps

🤖 All AI agent prompts combined

Task: 1

This phase upgrades counter_example's Android build configuration to resolve
Flutter deprecation warnings by updating AGP from 8.1.0 to 8.7.3, KGP from
1.8.22 to 2.1.0, and Gradle wrapper from 8.3 to 8.9.

**Plugin Version Updates:**
- In `examples/counter_example/android/settings.gradle`, locate the plugins
block (around line 21-22)
- Update the Android Gradle Plugin (AGP) version from 8.1.0 to 8.7.3
- Update the Kotlin Gradle Plugin (KGP) version from 1.8.22 to 2.1.0
- Preserve the existing Groovy DSL format

**Gradle Wrapper Update:**
- In `examples/counter_example/android/gradle/wrapper/gradle-wrapper.properties`
- Update the distributionUrl from gradle-8.3-all.zip to gradle-8.9-all.zip
- This ensures compatibility with AGP 8.7.x which requires Gradle 8.9 minimum
===============================================================================

Task: 2

This phase upgrades stac_gallery's Kotlin Gradle Plugin to resolve Flutter
deprecation warnings by updating KGP from 1.8.22 to 2.1.0.

**Plugin Version Update:**
- In `examples/stac_gallery/android/settings.gradle`, locate the plugins block
(around line 22)
- Update the `org.jetbrains.kotlin.android` plugin version from 1.8.22 to 2.1.0
- Preserve the existing Groovy DSL format
- Do not modify the AGP version (already at 8.7.3) or Gradle wrapper version
(already at 8.9)

💡 Iterate on the plan with: @coderabbitai <feedback>

Example Feedback
- `@coderabbitai` You can skip phase 3. Add a simple unit test case for phase 2.
- `@coderabbitai` For design choice 1 go ahead with option 3 and replan.

---

💬 Have feedback or questions? Drop into our discord!