Bad profiler can bubble exception to the caller of redis commands

[jdivy]

This might be a quick 'not our issue' ticket to close... but I recently discovered that by adding a profiler (thankfully not in production just yet) I was opening myself up to exceptions thrown by the profiler. I don't have the exact stack trace in hand any more but it was in a call to .Subscribe() on the multiplexer, making its way down to the profiling session .Invoke() call (link below).

Thought it worth asking the question "should a naughty profiler have any bearing on an otherwise perfectly good Redis command". I'm awaiting this fix in APM but I'm also now scared for future me when updating nuget...

elastic/apm-agent-dotnet#2292
 

StackExchange.Redis/src/StackExchange.Redis/ConnectionMultiplexer.cs

Line 1990 in 2f69707

var profilingSession = _profilingSessionProvider?.Invoke();

[NickCraver]

I'm trying to understand the question - are you saying the .Invoke() from a profiler is throwing internally? If so: yeah I'd say that's a profiler issue and not something we'd try/catch everywhere to prevent bad behavior on.

[jdivy]

Yep, that was basically the question - wasn't sure how extensive the use of the profiler .Invoke() was in the codebase so figured I'd ask to give you something to think about other than 'Timeout' tickets for a few minutes ;)