Skip to content

Commit 6fdf457

Browse files
EstoesMoisesEstoesMoises
committed
fix: fixed issue with SortParameters causing type errors
1 parent 6a298f0 commit 6fdf457

File tree

12 files changed

+62
-55
lines changed

12 files changed

+62
-55
lines changed

‎sdk/CHANGELOG.md‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
# so-teams-sdk
22

3+
## 1.1.2
4+
5+
### Patch Changes
6+
7+
- Fixed issue with Sort Parameters causing type errors
8+
39
## 1.1.1
410

511
### Patch Changes

‎sdk/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "so-teams-sdk",
3-
"version": "1.1.1",
3+
"version": "1.1.2",
44
"description": "SDK for Stack Overflow Teams API",
55
"main": "./dist/index.js",
66
"types": "./dist/index.d.ts",

‎sdk/src/client/answers.ts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ export interface CreateAnswerOptions {
2929
export interface GetAnswersOptions {
3030
page?: number;
3131
pageSize?: 15 | 30 | 50 | 100;
32-
sort?: AnswersSortParameter;
33-
order?: SortOrder;
32+
sort?: 'score' | 'modified' | 'creation' | AnswersSortParameter;
33+
order?: 'asc' | 'desc' | SortOrder;
3434
}
3535

3636
/**
@@ -111,12 +111,12 @@ export class AnswerClient extends BaseClient {
111111
return this.handleApiCall(async () => {
112112
if (this.teamId && this.teamsApi) {
113113
return await this.teamsApi.teamsTeamQuestionsQuestionIdAnswersGet(
114-
questionId, this.teamId, options.page, options.pageSize, options.sort, options.order
114+
questionId, this.teamId, options.page, options.pageSize, options.sort as AnswersSortParameter, options.order as SortOrder
115115
);
116116
}
117117

118118
return await this.mainApi.questionsQuestionIdAnswersGet(
119-
questionId, options.page, options.pageSize, options.sort, options.order
119+
questionId, options.page, options.pageSize, options.sort as AnswersSortParameter, options.order as SortOrder
120120
);
121121
}, 'getAll');
122122
}

‎sdk/src/client/articles.ts‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,8 @@ export interface UpdateArticleOptions {
5959
export interface GetArticlesOptions {
6060
page?: number;
6161
pageSize?: 15 | 30 | 50 | 100;
62-
sort?: ArticleSortParameter;
63-
order?: SortOrder;
62+
sort?: 'activity' | 'creation' | 'score' | ArticleSortParameter;
63+
order?: 'asc' | 'desc'| SortOrder;
6464
tagId?: Array<number>;
6565
authorId?: number;
6666
from?: Date;
@@ -171,8 +171,8 @@ export class ArticleClient extends BaseClient {
171171
this.teamId,
172172
options.page,
173173
options.pageSize,
174-
options.sort,
175-
options.order,
174+
options.sort as ArticleSortParameter,
175+
options.order as SortOrder,
176176
options.tagId,
177177
options.authorId,
178178
options.from,
@@ -183,8 +183,8 @@ export class ArticleClient extends BaseClient {
183183
return await this.mainApi.articlesGet(
184184
options.page,
185185
options.pageSize,
186-
options.sort,
187-
options.order,
186+
options.sort as ArticleSortParameter,
187+
options.order as SortOrder,
188188
options.tagId,
189189
options.authorId,
190190
options.from,

‎sdk/src/client/collections.ts‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -66,11 +66,11 @@ export interface UpdateCollectionOptions {
6666
export interface GetCollectionsOptions {
6767
page?: number;
6868
pageSize?: 15 | 30 | 50 | 100;
69-
sort?: CollectionsSortParameter;
70-
order?: SortOrder;
69+
sort?: 'creation' | 'lastEdit' | CollectionsSortParameter;
70+
order?: 'asc' | 'desc' | SortOrder;
7171
authorIds?: Array<number>;
7272
partialTitle?: string;
73-
permissions?: CollectionsPermissionsFilter;
73+
permissions?: 'all' | 'owned' | 'editable' | CollectionsPermissionsFilter;
7474
from?: Date;
7575
to?: Date;
7676
}
@@ -169,11 +169,11 @@ export class CollectionClient extends BaseClient {
169169
this.teamId,
170170
options.page,
171171
options.pageSize,
172-
options.sort,
173-
options.order,
172+
options.sort as CollectionsSortParameter,
173+
options.order as SortOrder,
174174
options.authorIds,
175175
options.partialTitle,
176-
options.permissions,
176+
options.permissions as CollectionsPermissionsFilter,
177177
options.from,
178178
options.to
179179
);
@@ -182,11 +182,11 @@ export class CollectionClient extends BaseClient {
182182
return await this.mainApi.collectionsGet(
183183
options.page,
184184
options.pageSize,
185-
options.sort,
186-
options.order,
185+
options.sort as CollectionsSortParameter,
186+
options.order as SortOrder,
187187
options.authorIds,
188188
options.partialTitle,
189-
options.permissions,
189+
options.permissions as CollectionsPermissionsFilter,
190190
options.from,
191191
options.to
192192
);

‎sdk/src/client/communities.ts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ import {
2020
export interface GetCommunitiesOptions {
2121
page?: number;
2222
pageSize?: 15 | 30 | 50 | 100;
23-
sort?: CommunitySortParameter;
24-
order?: SortOrder;
23+
sort?: 'name' | 'size' | CommunitySortParameter;
24+
order?: 'asc' | 'desc' | SortOrder;
2525
}
2626

2727
/**
@@ -111,8 +111,8 @@ export class CommunityClient extends BaseClient {
111111
return await this.mainApi.communitiesGet(
112112
options.page,
113113
options.pageSize,
114-
options.sort,
115-
options.order
114+
options.sort as CommunitySortParameter,
115+
options.order as SortOrder
116116
);
117117
}, 'getAll');
118118
}

‎sdk/src/client/questions.ts‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,8 @@ export interface UpdateQuestionOptions {
5656
export interface GetQuestionsOptions {
5757
page?: number;
5858
pageSize?: 15 | 30 | 50 | 100;
59-
sort?: QuestionSortParameter;
60-
order?: SortOrder;
59+
sort?: 'activity' | 'creation' | 'score' | QuestionSortParameter;
60+
order?: 'asc' | 'desc' | SortOrder;
6161
isAnswered?: boolean;
6262
hasAcceptedAnswer?: boolean;
6363
questionId?: Array<number>;
@@ -172,8 +172,8 @@ export class QuestionClient extends BaseClient {
172172
this.teamId,
173173
options.page,
174174
options.pageSize,
175-
options.sort,
176-
options.order,
175+
options.sort as QuestionSortParameter,
176+
options.order as SortOrder,
177177
options.isAnswered,
178178
options.hasAcceptedAnswer,
179179
options.questionId,
@@ -187,8 +187,8 @@ export class QuestionClient extends BaseClient {
187187
return await this.mainApi.questionsGet(
188188
options.page,
189189
options.pageSize,
190-
options.sort,
191-
options.order,
190+
options.sort as QuestionSortParameter,
191+
options.order as SortOrder,
192192
options.isAnswered,
193193
options.hasAcceptedAnswer,
194194
options.questionId,
@@ -486,7 +486,7 @@ export class QuestionClient extends BaseClient {
486486
options.page,
487487
options.pageSize,
488488
options.sort,
489-
options.order
489+
options.order as SortOrder
490490
);
491491
}
492492

@@ -495,7 +495,7 @@ export class QuestionClient extends BaseClient {
495495
options.page,
496496
options.pageSize,
497497
options.sort,
498-
options.order
498+
options.order as SortOrder
499499
);
500500
}, 'getLinked');
501501
}
@@ -533,7 +533,7 @@ export class QuestionClient extends BaseClient {
533533
options.page,
534534
options.pageSize,
535535
options.sort,
536-
options.order
536+
options.order as SortOrder
537537
);
538538
}
539539

@@ -542,7 +542,7 @@ export class QuestionClient extends BaseClient {
542542
options.page,
543543
options.pageSize,
544544
options.sort,
545-
options.order
545+
options.order as SortOrder
546546
);
547547
}, 'getRelated');
548548
}

‎sdk/src/client/search.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export interface SearchOptions {
1717
query?: string;
1818
page?: number;
1919
pageSize?: 15 | 30 | 50 | 100;
20-
sort?: SearchSortParameter;
20+
sort?: 'relevance' | 'newest' | 'active' | 'score' | SearchSortParameter;
2121
}
2222

2323
/**
@@ -116,15 +116,15 @@ export class SearchClient extends BaseClient {
116116
options.query,
117117
options.page,
118118
options.pageSize,
119-
options.sort
119+
options.sort as SearchSortParameter
120120
);
121121
}
122122

123123
return await this.mainApi.searchGet(
124124
options.query,
125125
options.page,
126126
options.pageSize,
127-
options.sort
127+
options.sort as SearchSortParameter
128128
);
129129
}, 'search');
130130
}

‎sdk/src/client/tags.ts‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ import {
2424
export interface GetTagsOptions {
2525
page?: number;
2626
pageSize?: 15 | 30 | 50 | 100;
27-
sort?: TagsSortParameter;
28-
order?: SortOrder;
27+
sort?: 'name' | 'postCount' | 'creationDate' | TagsSortParameter;
28+
order?: 'asc' | 'desc' | SortOrder;
2929
partialName?: string;
3030
hasSmes?: boolean;
3131
hasSynonyms?: boolean;
@@ -131,8 +131,8 @@ export class TagClient extends BaseClient {
131131
this.teamId,
132132
options.page,
133133
options.pageSize,
134-
options.sort,
135-
options.order,
134+
options.sort as TagsSortParameter,
135+
options.order as SortOrder,
136136
options.partialName,
137137
options.hasSmes,
138138
options.hasSynonyms
@@ -142,8 +142,8 @@ export class TagClient extends BaseClient {
142142
return await this.mainApi.tagsGet(
143143
options.page,
144144
options.pageSize,
145-
options.sort,
146-
options.order,
145+
options.sort as TagsSortParameter,
146+
options.order as SortOrder,
147147
options.partialName,
148148
options.hasSmes,
149149
options.hasSynonyms

‎sdk/src/client/userGroups.ts‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ export interface UpdateUserGroupOptions {
4343
export interface GetUserGroupsOptions {
4444
page?: number;
4545
pageSize?: 15 | 30 | 50 | 100;
46-
sort?: UserGroupsSortParameter;
47-
order?: SortOrder;
46+
sort?: 'name' | 'size' | UserGroupsSortParameter;
47+
order?: 'asc' | 'desc' | SortOrder;
4848
}
4949

5050
/**
@@ -131,16 +131,16 @@ export class UserGroupClient extends BaseClient {
131131
this.teamId,
132132
options.page,
133133
options.pageSize,
134-
options.sort,
135-
options.order
134+
options.sort as UserGroupsSortParameter,
135+
options.order as SortOrder
136136
);
137137
}
138138

139139
return await this.mainApi.userGroupsGet(
140140
options.page,
141141
options.pageSize,
142-
options.sort,
143-
options.order
142+
options.sort as UserGroupsSortParameter,
143+
options.order as SortOrder
144144
);
145145
}, 'getAll');
146146
}

0 commit comments

Comments
 (0)