Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CICD: Add golangci-lint-action to CI/CD pipeline #3313

Open
tlimoncelli opened this issue Jan 6, 2025 · 0 comments
Open

CICD: Add golangci-lint-action to CI/CD pipeline #3313

tlimoncelli opened this issue Jan 6, 2025 · 0 comments
Assignees
Labels
github_actions Pull requests that update Github_actions code

Comments

@tlimoncelli
Copy link
Contributor

tlimoncelli commented Jan 6, 2025

Is your feature request related to a problem? Please describe.

It would be nice to enforce the default golangci-lint linters.

Describe the solution you'd like

Add this to the PR pipeline: https://github.com/golangci/golangci-lint-action

  • Run with the "default" linters. Not "all".
  • Add linter "predeclared" (but it should skip integrationTest/integration_test.go).
    • NOTE: integration_test.go has been remediated. No need to skip it. --Tom 2025-01-08
  • Add linter "godot" but not until bug (Multi-line comments disappear tetafro/godot#39) is fixed.
  • Add these linters. They currently have no findings but might in the future:
    • asasalint
    • asciicheck
    • bidichk
    • decorder
    • durationcheck
  • Investigate these linters. They will require code changes but they seem to have value.
    • containedctx
    • bodyclose
    • copyloopvar
    • errname
    • errorlint

Describe alternatives you've considered
n/a

Additional context
n/a

@cafferata cafferata self-assigned this Jan 6, 2025
@cafferata cafferata added the github_actions Pull requests that update Github_actions code label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Development

No branches or pull requests

2 participants