Skip to content

[BUG] Error preventing ship spawning #25

@lectronyx

Description

@lectronyx

Round ID:

24

Testmerges:

Reproduction:

Try to spawn a ship, and it might not work.

Have some runtimes:

[2024-01-07 20:22:12] Runtime in outpost.dm, line 259: Cannot read null.name

proc name: post undocked (/datum/overmap/outpost/post_undocked)
usr: CourierAsy/(CourierAsy)
usr.loc: (start area (9, 21, 1))
src: Echard Hub (/datum/overmap/outpost/indie_space)
call stack:
Echard Hub (/datum/overmap/outpost/indie_space): post undocked(null)
overmap vessel (/datum/overmap/ship/controlled): Destroy(0)
overmap vessel (/datum/overmap/ship/controlled): Destroy(0)
overmap vessel (/datum/overmap/ship/controlled): Destroy(0)
qdel(overmap vessel (/datum/overmap/ship/controlled), 0)
overmap vessel (/datum/overmap/ship/controlled): Initialize(Echard Hub (/datum/overmap/outpost/indie_space), Mudskipper-class Salvage Clipp... (/datum/map_template/shuttle), 1)
overmap vessel (/datum/overmap/ship/controlled): New(Echard Hub (/datum/overmap/outpost/indie_space), Mudskipper-class Salvage Clipp... (/datum/map_template/shuttle))
Overmap (/datum/controller/subsystem/overmap): spawn ship at start(Mudskipper-class Salvage Clipp... (/datum/map_template/shuttle))
/datum/ship_select (/datum/ship_select): ui act("buy", /list (/list), /datum/tgui (/datum/tgui), /datum/ui_state/always_state (/datum/ui_state/always_state))
/datum/tgui (/datum/tgui): on act message("buy", /list (/list), /datum/ui_state/always_state (/datum/ui_state/always_state))
/datum/callback/verb_callback (/datum/callback/verb_callback): InvokeAsync()

[2024-01-07 20:22:42] Runtime in outpost.dm, line 259: Cannot read null.name

proc name: post undocked (/datum/overmap/outpost/post_undocked)
usr: CourierAsy/(CourierAsy)
usr.loc: (start area (9, 21, 1))
src: Echard Hub (/datum/overmap/outpost/indie_space)
call stack:
Echard Hub (/datum/overmap/outpost/indie_space): post undocked(null)
overmap vessel (/datum/overmap/ship/controlled): Destroy(0)
overmap vessel (/datum/overmap/ship/controlled): Destroy(0)
overmap vessel (/datum/overmap/ship/controlled): Destroy(0)
qdel(overmap vessel (/datum/overmap/ship/controlled), 0)
overmap vessel (/datum/overmap/ship/controlled): Initialize(Echard Hub (/datum/overmap/outpost/indie_space), Mudskipper-class Salvage Clipp... (/datum/map_template/shuttle), 1)
overmap vessel (/datum/overmap/ship/controlled): New(Echard Hub (/datum/overmap/outpost/indie_space), Mudskipper-class Salvage Clipp... (/datum/map_template/shuttle))
Overmap (/datum/controller/subsystem/overmap): spawn ship at start(Mudskipper-class Salvage Clipp... (/datum/map_template/shuttle))
/datum/ship_select (/datum/ship_select): ui act("buy", /list (/list), /datum/tgui (/datum/tgui), /datum/ui_state/always_state (/datum/ui_state/always_state))
/datum/tgui (/datum/tgui): on act message("buy", /list (/list), /datum/ui_state/always_state (/datum/ui_state/always_state))
/datum/callback/verb_callback (/datum/callback/verb_callback): InvokeAsync()

The line in question appears to be:

	"[dock_requester.name] has departed from [src].",

It might be trying to spawn a nameless ship?

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions