New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate/Remove Storage & Monitoring NodePools #1979

Closed

Souheil-Yazji opened this issue Oct 2, 2024 · 4 comments

Assignees

Labels

kind/bug triage/support

Contributor

Souheil-Yazji commented Oct 2, 2024

Continuation of #1967

No usage of the monitoring nodepool found.
Storage nodepool found at https://github.com/StatCan/terraform-kubernetes-aks-daaas-private/blob/master/aks.tf#L133 -> Archived

Can safely assume that these can be deprecated, check for dev and prod.

Souheil-Yazji added kind/bug triage/support labels

Souheil-Yazji assigned EveningStarlight

EveningStarlight commented Oct 7, 2024

PR ready at
https://gitlab.k8s.cloud.statcan.ca/cloudnative/aaw/modules/terraform-azure-statcan-aaw-environment/-/merge_requests/52

Contributor Author

Souheil-Yazji commented Oct 15, 2024

The following needs to be updated: https://gitlab.k8s.cloud.statcan.ca/cloudnative/aaw/terraform-advanced-analytics-workspaces-infrastructure/-/blob/main/dev_cc_00.tf?ref_type=heads

Detailed how-to described here: https://gitlab.k8s.cloud.statcan.ca/cloudnative/aaw/terraform-advanced-analytics-workspaces-infrastructure#add-a-new-node-pool-and-subnet

EveningStarlight commented Oct 15, 2024

Second PR ready at:
https://gitlab.k8s.cloud.statcan.ca/cloudnative/aaw/terraform-advanced-analytics-workspaces-infrastructure/-/merge_requests/321

Souheil-Yazji closed this as completed

Contributor Author

Souheil-Yazji commented Oct 22, 2024

PRs merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment