Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically restart apps when configmaps change #772

Closed
blairdrummond opened this issue Dec 3, 2021 · 3 comments
Closed

Automatically restart apps when configmaps change #772

blairdrummond opened this issue Dec 3, 2021 · 3 comments
Assignees

Comments

@blairdrummond
Copy link
Contributor

Might leverage this

https://github.com/xing/kubernetes-deployment-restart-controller

Some apps (goofys injector, minio credential injector, etc) fetch values from a configmap, and do not restart when those settings change.
This means that the gitops flow is a bit manual, even with ArgoCD. We might want a way to automate some rollouts

@Jose-Matsuda
Copy link
Contributor

Additionally look at https://github.com/stakater/Reloader/

@Jose-Matsuda
Copy link
Contributor

Jose-Matsuda commented Nov 20, 2023

The PR is in dev here https://github.com/StatCan/aaw-argocd-manifests/pull/361

Here is a list of configmaps that may be modified a lot causing us needing to do restarts.

grafana-alerting-cm
oidc-authservice-parameters
centraldashboard-config
jupyter-web-app-config --> maybe anything with jwa
notebook-controller-config

ON PROD (we don't have this cm on dev)
non-employee-exceptions
TBD (dev stuff)

apm-server-cm
otelcollector-collector
trino

I took a look at some secrets but they seem inconsequential for the most part / they would be covered by the deployments / resources that would get annotated by the cms anyways.
So we just annotate the resources that use these cms and then bam we're set (at least for dev). And of course if we see one missing we can just add it later, its a single annotation and boom it's done

@Jose-Matsuda
Copy link
Contributor

Closing as completed for DEV. Synched up changed deployments, made changes to the configmap and observed restarts.

Follow up for PROD here; #1899

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants