Disable Hotkey On Settings Menu

[Stateford]

Currently the hotkey button is enabled on the settings menu and should be temporarily disabled until the tab is switched. The key should be unregistered, and re-registered after the switch.
The current hotkey should appear in the Hotkey control box

[ghost]

Hello @idietmoran! Is this issue up for grabs?

[Stateford]

It is. I'm thinking the hotkey should be unregistered when a user navigates to the settings page, and reregistered when the user navigates away.

Make sure you do it on the develop branch.

Line 370-374 is where the switching is detected.

Thanks!

[ghost]

@idietmoran I was wondering if I could potentially get some more clarification on the hotkey. I'm a little confused on what the hotkey is. Are you referring to the Settings options such as "Minimize on start", "Bring window to foreground", etc.?

[Stateford]

Currently this feature is only enabled on the develop branch.

There should be a small box at the bottom of the window that you can click into and set a hotkey.
Currently any registered hotkey will still activate while on this window.

Check hotkey.c in dispLib for more information.

The hotkey information is stored in a struct HOTKEY which is also in a struct SETTINGS.

Check common.h for struct implementations.

[ghost]

Awesome. Thanks! That clarifies a lot. I didn't see the develop branch and was on the master branch when I opened up the project in VS.

[Stateford]

Yep, all work should be done on develop, or a branch checked out from develop.

Any tests you may want to add would be appreciated as well (although a lot of this stuff is hard to test against)

[Stateford]

Unfortunately this is going to have to wait for #42 which was just reopened. I'm not sure if you're still working on this, but someone found a bug with the method we used.

[ghost]

No problem @idietmoran . I was still in the process of getting acquainted with the codebase as it's my first time working with a WinAPI application so not much was changed on my end yet. Thanks for the heads up!