Fix problem with aggregation functions

Author: efcaguab

DESCRIPTION

@@ -1,7 +1,7 @@
 Package: er.helpers
 Type: Package
 Title: Helper functions commonly used in Environmental Reporting at Stats NZ
-Version: 1.1.1
+Version: 1.1.2
 Authors@R: c(
     person("Fernando", "Cagua", email = "fernando.cagua@stats.govt.nz", role = c("aut", "cre")), 
     person("David", "Hodge", email = "david.hodge@stats.govt.nz", role = c("aut")), 

NEWS.md

@@ -1,3 +1,7 @@
+## er.helpers 1.1.1
+
+* Bug fix: aggregation functions now return NA as expected when all values are missing. Even if it passes other requirements.
+
 ## er.helpers 1.1.0
 
 * New feature: Added all palettes from simplevis, plus a signed square root trans function scales. 

R/aggregation.R

@@ -28,6 +28,10 @@ aggregate_with_criteria <- function(x, max_missing = 0, max_consecutive = 0, fun
   n_missing <- sum(na_values)
   prop_missing <- n_missing / length(x)
 
+  # Don't need to calculate anything else if everything is missing
+  if (prop_missing == 1)
+    return(NA)
+
   # If max missing is a proportion
   if (max_missing <= 1 & max_missing > 0) {
     if (prop_missing > max_missing)

tests/testthat/test-aggregation.R

@@ -0,0 +1,8 @@
+test_that("aggregation functions work", {
+
+  # Test that functions return NA when everything is NA, even if the number is
+  # below requirements
+  expect_equal(mean_with_criteria(rep(NA), 10, 4), NA)
+  expect_equal(min_with_criteria(rep(NA), 10, 4), NA)
+  expect_equal(max_with_criteria(rep(NA), 10, 4), NA)
+})