-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Current Behavior
The cancellation token should be forwarded to the context.
public virtual async Task<CommandResult> ExecuteAsync( TStart argument, CancellationToken cancellation = default )
{
var context = ContextFactory.Create( Logger ); // Here is the bug.
await Pipeline.Value( context, argument ).ConfigureAwait( false );
return new CommandResult
{
Context = context,
CommandType = GetType()
};
}Expected Behavior
Should forward it.
public virtual async Task<CommandResult> ExecuteAsync( TStart argument, CancellationToken cancellation = default )
{
var context = ContextFactory.Create( Logger, cancellation );
await Pipeline.Value( context, argument ).ConfigureAwait( false );
return new CommandResult
{
Context = context,
CommandType = GetType()
};
}Steps To Reproduce
- Pass a token and see that a new one is made
Anything else?
No response
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working