Change the default material on empty material slots to exporter aborting #115
ssnd292
started this conversation in
Ideas & Feature Requests
Replies: 1 comment 1 reply
-
I support the idea, but I do think a change in architecture to 'validate' the scene before starting the export would probably be needed (or some kind of dry-run like implementation), because I don't think the current structure supports breaking off the process like that very well, especially not that deep in the call hierarchy. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Regarding #114
I've always had the standpoint of educating users by forcing them to correctly prepare models for exporting by not allowing bad practices.
In Blender, one of them is having a model with empty material slots. While the idea behind those in Blender themselves are questionable, it's an easy fix itself.
Putting another material into those empty slots does not fix the problem - it convolutes the object data and adds more drawcalls than necessary.
So instead of simply assigning a default material to an object that has an empty material slot, the exporter should:
...stop exporting at all and give a warning in the log and display
or
... stop exporting that particular object with that empty slot.
(Don't confuse this with having a mesh with no material slot at all - adding a default material here is just fine for debug or prototype purposes)
Beta Was this translation helpful? Give feedback.
All reactions