Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with YouTube material layout #1

Open
Keith94 opened this issue Aug 29, 2017 · 8 comments
Open

Doesn't work with YouTube material layout #1

Keith94 opened this issue Aug 29, 2017 · 8 comments
Labels
enhancement patch welcome User is free to propose own implementation of the requested feature

Comments

@Keith94
Copy link

Keith94 commented Aug 29, 2017

Great add-on!

One issue: with YouTube's material layout turned on, the add-on stops working on youtube.com.

I'm using version 0.0.1 because 0.0.2 was reported to be corrupt.

@StoyanDimitrov
Copy link
Owner

Hey, great to hear!
This is a general shortcoming of the current implementation that I'm willing to overcome. Unfortunately, I forgot to mention it in the description.

P.S. I've just resent the add-on for review to fix the corruption.

@Keith94
Copy link
Author

Keith94 commented Aug 30, 2017

Thanks for the fast reply. :)

I noticed the add-on also wasn't working inside some scrollable elements like here: https://en.wikipedia.org/w/index.php?title=Cave_Story&action=edit
You could also mention that it doesn't work on addons.mozilla.org. Or the file:// and moz-extension:// protocols.

Off topic: Is it possible to make the cursor locked in the same place while scrolling? Also right now I think the cursor moves a bit slower than the actual page's scroll bar (not 1:1 movement)?

@StoyanDimitrov
Copy link
Owner

The problem you describe is basically the same as the YouTube one and will be fixed with this issue.

No add-on work on several of mozilla.org websites for now. There's a Bugzilla issue describing the reasons.

Right now there is a ratio of 0.8:1 (mouse movement to page scroll) so one can click on the upper part (assuming downward scroll) of the page and still be able to scroll down to the very bottom or at least very close to it. If the ratio were 1:1 you have to aim the click to the very top of the page which I find inconvenient since there are other parts of the browser chrome: search bar, address bar, add-on bar, bookmarks bar etc. This way if you click at the top 10% of the page heigh you are guaranteed to scroll to the bottom. Still, if you find this inconvenient file a separate issue. Please do the same for the cursor locking request.

@Keith94
Copy link
Author

Keith94 commented Aug 30, 2017

Good point! Your explanation makes sense. I will file a separate issue for the cursor locking. :)

@Keith94
Copy link
Author

Keith94 commented Aug 30, 2017

Btw, I noticed when a webpage didn't finish loading completely and you try to scroll, the add-on doesn't work at that point (only uses regular autoscrolling). Is that a separate issue or can it be fixed?

@StoyanDimitrov
Copy link
Owner

Good catch! It surely can be fixed.

@Keith94
Copy link
Author

Keith94 commented Jul 31, 2018

Is this abandoned?

@StoyanDimitrov
Copy link
Owner

StoyanDimitrov commented Aug 1, 2018

The add-on is not abandoned. The issue fell off my radar.

@StoyanDimitrov StoyanDimitrov added the patch welcome User is free to propose own implementation of the requested feature label Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement patch welcome User is free to propose own implementation of the requested feature
Projects
None yet
Development

No branches or pull requests

2 participants