Bug/branch duplicate fragments (#1803)

* Corrected bug in user plugins files

* Fragments duplication corrected

Author: compae

serving-core/src/main/scala/com/stratio/sparta/serving/core/utils/FragmentUtils.scala

@@ -68,9 +68,8 @@ trait FragmentUtils extends SLF4JLogging with SpartaSerializer {
     findFragmentsByType(fragmentType).find(fragment => fragment.name == name)
 
   def createFragment(fragment: FragmentElementModel): FragmentElementModel =
-    if (existsByTypeAndName(fragment.fragmentType, fragment.name.toLowerCase))
-      getExistingFragment(fragment).getOrElse(createNewFragment(fragment))
-    else createNewFragment(fragment)
+    findFragmentByTypeAndName(fragment.fragmentType, fragment.name.toLowerCase)
+      .getOrElse(createNewFragment(fragment))
 
   def updateFragment(fragment: FragmentElementModel): FragmentElementModel = {
     val newFragment = fragment.copy(name = fragment.name.toLowerCase)
@@ -147,18 +146,6 @@ trait FragmentUtils extends SLF4JLogging with SpartaSerializer {
     }
   }
 
-  private def getExistingFragment(fragment: FragmentElementModel): Option[FragmentElementModel] =
-    findFragmentsByType(fragment.fragmentType)
-      .dropWhile(currentFragment => !fragment.equals(currentFragment)).headOption
-
-  private def existsByTypeAndName(fragmentType: String, name: String, id: Option[String] = None): Boolean = {
-    findFragmentsByType(fragmentType).exists(fragment =>
-      if (id.isDefined && fragment.id.isDefined)
-        fragment.name == name && fragment.id.get != id.get
-      else fragment.name == name
-    )
-  }
-
   /* POLICY METHODS */
 
   def getPolicyWithFragments(policy: PolicyModel): PolicyModel = {